Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
id: bugfix-840
title: codev-telemetry-setting-descri
protocol: bugfix
phase: verified
plan_phases: []
current_plan_phase: null
gates: {}
iteration: 1
build_complete: false
history: []
started_at: '2026-05-26T05:44:36.920Z'
updated_at: '2026-05-26T05:53:44.759Z'
43 changes: 43 additions & 0 deletions codev/state/bugfix-840_thread.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
# bugfix-840 thread

## Investigate (2026-05-26)

Issue #840 asks to remove the dead `codev.telemetry` setting from
`packages/vscode/package.json`. Setting has zero code consumers (verified by
grep across `packages/`).

Found 2 references in `packages/vscode/`:
- `package.json:534` — the declaration itself
- `README.md:218` — table row documenting the setting

Both must go; the issue's acceptance criterion is "no remaining reference to
`codev.telemetry` anywhere in `packages/vscode/`".

## Fix (2026-05-26)

- Removed entry from `packages/vscode/package.json`
- Removed row from `packages/vscode/README.md`
- Added regression test at `packages/vscode/src/__tests__/codev-telemetry-removed.test.ts`
asserting `contributes.configuration.properties` doesn't carry the key
- `pnpm test:unit` → 35/35 pass (5 files, includes the new regression test)
- `pnpm check-types` → passes (after building core+types deps in the worktree)
- Diff size: 23 additions, 6 deletions, 3 files — well under 300 LOC
- Commit: `fb6bd5c4` — `Fix #840: Remove dead codev.telemetry setting`

The local analytics surface in `packages/codev/src/agent-farm/servers/analytics.ts`
is untouched per the issue's "out of scope" note — it is local-only and not
gated by this setting.

## PR (2026-05-26)

- PR #865 created: https://github.com/cluesmith/codev/pull/865
- CMAP 3-way verdicts (`consult --protocol bugfix --type pr --issue 840`):
- gemini: **APPROVE** (HIGH confidence, no key issues)
- codex: **APPROVE** (HIGH confidence, no key issues)
- claude: **APPROVE** (HIGH confidence, no key issues)
- Notified architect with PR link + all three verdicts via `afx send architect`

Note: first CMAP attempt failed with "Multiple projects found" — auto-project
detection inside the worktree didn't disambiguate. Retried with `--issue 840`
which worked. Likely worth tracking as a follow-up if reproducible (would
affect any builder spawned in a workspace that lists many projects).
1 change: 0 additions & 1 deletion packages/vscode/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,6 @@ When a builder reaches a human-approval gate, a toast surfaces it with the issue
| `codev.gateToasts.enabled` | `true` | Show a toast when a builder reaches a human-approval gate |
| `codev.buildersAutoCollapse` | `true` | Builders view accordion — expanding one builder auto-collapses the others |
| `codev.buildersFileViewAsTree` | `true` | Render a builder's changed-files list as a folder tree (`false` for a flat list) |
| `codev.telemetry` | `false` | No telemetry collected |

## Advanced

Expand Down
5 changes: 0 additions & 5 deletions packages/vscode/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -531,11 +531,6 @@
"default": true,
"description": "Auto-start Tower if not running on activation"
},
"codev.telemetry": {
"type": "boolean",
"default": false,
"description": "No telemetry collected"
},
"codev.autoOpenBuilderTerminal": {
"type": "string",
"enum": ["off", "notify", "auto"],
Expand Down
23 changes: 23 additions & 0 deletions packages/vscode/src/__tests__/codev-telemetry-removed.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
/**
* Regression test for issue #840.
*
* The `codev.telemetry` configuration entry was removed because it had zero
* code consumers — it surfaced in VS Code's Settings UI as a toggle that did
* nothing. This test asserts the entry stays out of `package.json` so it
* doesn't get re-added by accident.
*/

import { describe, it, expect } from 'vitest';
import { readFileSync } from 'node:fs';
import { resolve } from 'node:path';

const PKG = JSON.parse(
readFileSync(resolve(__dirname, '../../package.json'), 'utf8'),
);

describe('issue #840 — codev.telemetry setting removed', () => {
it('does not declare codev.telemetry in contributes.configuration.properties', () => {
const props = PKG.contributes?.configuration?.properties ?? {};
expect(props).not.toHaveProperty('codev.telemetry');
});
});
Loading