Fix #840: Remove dead codev.telemetry setting#865
Merged
Conversation
The codev.telemetry entry in packages/vscode/package.json had zero code
consumers — it surfaced in VS Code's Settings UI as a toggle that did
nothing, and its description ("No telemetry collected") read as a
disclaimer rather than control text.
Remove the entry from package.json and the matching row from the
extension README. Add a regression test asserting the property stays
absent from contributes.configuration.properties.
Codev does not collect external telemetry; the local analytics surface
in packages/codev/src/agent-farm/servers/analytics.ts is local-only and
unrelated to this setting (left untouched).
Collaborator
Author
Architect ReviewLow-risk change. Setting removed per Option B (the issue's revised direction). CMAP unanimous (gemini=APPROVE, codex=APPROVE, claude=APPROVE). Verified:
Approved. Please merge. Architect review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
codev.telemetrysetting inpackages/vscode/package.jsonhad zero code consumers — it surfaced in VS Code's Settings UI as a toggle that did nothing, and its description ("No telemetry collected") read as a disclaimer rather than control text. Removing it matches the current behavior (codev collects no external telemetry) and removes a user-visible footgun.Fixes #840
Root Cause
The setting was declared in
contributes.configuration.propertiesbut never read by any path inpackages/**. Verified by grep ontelemetry/TelemetryReporter/sendTelemetryEvent/appInsights— the setting key had no reader.Fix
codev.telemetryentry frompackages/vscode/package.json#contributes.configuration.propertiesREADME.mdsettings tablepackages/vscode/src/__tests__/codev-telemetry-removed.test.ts) asserting the property stays absent fromcontributes.configuration.propertiesThe local analytics surface in
packages/codev/src/agent-farm/servers/analytics.tsis local-only (not telemetry) and is untouched, per the issue's out-of-scope note.Test Plan
codev-telemetry-removed.test.ts)pnpm test:unit— 35/35 passpnpm check-types— passesgrep -rn "codev.telemetry" packages/vscode/— zero hits after fixCodev