Skip to content

Remove scope field when crate report policy #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ImMin5 merged 1 commit into from
May 21, 2025
Merged

Remove scope field when crate report policy #581

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 6 additions & 13 deletions proto/spaceone/api/cost_analysis/v1/report_adjustment_policy.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,23 +67,16 @@ message AdjustmentPolicyFilter {
repeated string project_ids = 2;
}

message CreateReportAdjustmentPolicyRequest {
enum Scope {
SCOPE_NONE = 0;
WORKSPACE = 1;
PROJECT = 2;
SERVICE_ACCOUNT = 3;
}
Scope scope = 1;
string cost_report_config_id = 2;
message CreateReportAdjustmentPolicyRequest {;
string cost_report_config_id = 1;
// +optional
int32 order = 3;
int32 order = 2;
Comment on lines +71 to +73
Copy link

Copilot AI May 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since scope previously occupied tag 1, add a reserved 1; (and optionally reserved "scope";) directive in the message to prevent reuse of that tag and maintain backward compatibility.

Copilot uses AI. Check for mistakes.
// +optional
string description = 4;
string description = 3;
// +optional
google.protobuf.Struct tags = 5;
google.protobuf.Struct tags = 4;
// +optional
AdjustmentPolicyFilter policy_filter = 6;
AdjustmentPolicyFilter policy_filter = 5;
}

message UpdateReportAdjustmentPolicyRequest {
Expand Down
Loading