Remove scope field when crate report policy #581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ImMin5 <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
Removes the deprecated scope enum and field from CreateReportAdjustmentPolicyRequest and renumbers subsequent fields.
- Drop
Scopeenum andscopefield - Shift
cost_report_config_id,order,description,tags, andpolicy_filtertags down by one - Missing declaration to reserve the old tag number
Comments suppressed due to low confidence (1)
proto/spaceone/api/cost_analysis/v1/report_adjustment_policy.proto:70
- The semicolon after the opening brace is a syntax error. Remove the
;so the message declaration readsmessage CreateReportAdjustmentPolicyRequest {.
message CreateReportAdjustmentPolicyRequest {;
Comment on lines
+71
to
+73
| string cost_report_config_id = 1; | ||
| // +optional | ||
| int32 order = 3; | ||
| int32 order = 2; |
There was a problem hiding this comment.
Since scope previously occupied tag 1, add a reserved 1; (and optionally reserved "scope";) directive in the message to prevent reuse of that tag and maintain backward compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category
Description
Known issue