Skip to content

Conversation

@Bianka2112
Copy link
Contributor

@Bianka2112 Bianka2112 commented Oct 10, 2025

WHAT is this pull request doing?

  • Add live regex filter and new render logic for logs view.
  • Waits to render 1000 logs, lists up to 2000 total, with small batches on rerender if fire-hosed.
  • Adds loading status

HOW can this pull request be tested?

  • Checkout branch, try filter box at the top.
  • I tested locally with a fake logs burst, to check for smooth batching.
  • Happy to get feedback/recommendations on the UX + rendering, since I dont get much stream in my own dev env to see how it feels "live".

Copy link
Member

@carlhoerberg carlhoerberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested but the code looks generally sound, except we prefer the function declarations instead of assignments.

}

// Build Table
const buildRow = (log) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefer function declaration to assignment

Suggested change
const buildRow = (log) => {
function buildRow(log) {

const INITIAL_ROWS = 1000
const ROWS_PER_FLUSH = 200
const BOOT_MIN_LOGS = INITIAL_ROWS
const BOOT_MAX = 10000
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We wait 10s or for 1000 lines to arrive before doing first rendering? I think that might be a bit too long.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea was a high enough threshold that would avoid too much flutter if theres a lot of backlog, but can absolutely bring it down. Would 500ms feel better?
In my testing, 500ms still allows the loading status to appear and renders batches without too much repainting. WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants