-
Notifications
You must be signed in to change notification settings - Fork 42
filter for logs #1347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Bianka2112
wants to merge
4
commits into
cloudamqp:main
Choose a base branch
from
Bianka2112:temp-branch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
filter for logs #1347
Changes from 3 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,28 +1,37 @@ | ||||||
| let shouldAutoScroll = true | ||||||
| const evtSource = new window.EventSource('api/livelog') | ||||||
| const livelog = document.getElementById('livelog') | ||||||
| const tbody = document.getElementById('livelog-body') | ||||||
| const filterInput = document.getElementById('log-filter') | ||||||
| const table = document.getElementById('table') | ||||||
| const loading = document.getElementById('log-loading') | ||||||
| const bootTime = performance.now() | ||||||
|
|
||||||
| evtSource.onmessage = (event) => { | ||||||
| const timestamp = new Date(parseInt(event.lastEventId)) | ||||||
| const [severity, source, message] = JSON.parse(event.data) | ||||||
| const allLogs = [] | ||||||
| const pendingLogs = [] | ||||||
|
|
||||||
| const tdTs = document.createElement('td') | ||||||
| tdTs.textContent = timestamp.toLocaleString() | ||||||
| const tdSev = document.createElement('td') | ||||||
| tdSev.textContent = severity | ||||||
| const tdSrc = document.createElement('td') | ||||||
| tdSrc.textContent = source | ||||||
| const preMsg = document.createElement('pre') | ||||||
| preMsg.textContent = message | ||||||
| const tdMsg = document.createElement('td') | ||||||
| tdMsg.appendChild(preMsg) | ||||||
| const MAX_ROWS = 2000 | ||||||
| const INITIAL_ROWS = 1000 | ||||||
| const ROWS_PER_FLUSH = 200 | ||||||
| const BOOT_MIN_LOGS = INITIAL_ROWS | ||||||
| const BOOT_MAX = 10000 | ||||||
| const FLUSH_MS = 1000 | ||||||
|
|
||||||
| const tr = document.createElement('tr') | ||||||
| tr.append(tdTs, tdSev, tdSrc, tdMsg) | ||||||
| const row = tbody.appendChild(tr) | ||||||
| let shouldAutoScroll = true | ||||||
| let currentRegex = null | ||||||
| let booting = true | ||||||
| let flushTimer = null | ||||||
|
|
||||||
| if (shouldAutoScroll) row.scrollIntoView() | ||||||
| // SSE | ||||||
| evtSource.onmessage = (event) => { | ||||||
| const timestamp = new Date(parseInt(event.lastEventId)) | ||||||
| const [severity, source, message] = JSON.parse(event.data) | ||||||
| const log = { timestamp, severity, source, message } | ||||||
| pendingLogs.push(log) | ||||||
| if (booting) { | ||||||
| table.style.visibility = 'hidden' | ||||||
| loading.hidden = false | ||||||
| } | ||||||
| scheduleFlush() | ||||||
| } | ||||||
|
|
||||||
| evtSource.onerror = () => { | ||||||
|
|
@@ -41,6 +50,149 @@ function forbidden () { | |||||
| tblError.style.display = 'block' | ||||||
| } | ||||||
|
|
||||||
| // Build Table | ||||||
| const buildRow = (log) => { | ||||||
|
||||||
| const buildRow = (log) => { | |
| function buildRow(log) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We wait 10s or for 1000 lines to arrive before doing first rendering? I think that might be a bit too long.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea was a high enough threshold that would avoid too much flutter if theres a lot of backlog, but can absolutely bring it down. Would 500ms feel better?
In my testing, 500ms still allows the loading status to appear and renders batches without too much repainting. WDYT?