Skip to content

Use dynamic imports to fix issues in the release process #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2025
Merged

Use dynamic imports to fix issues in the release process #365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions scripts/preparepackages.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,10 @@ const tasks = new Listr( [
},
{
title: 'Creating the `ckeditor5-vue` package in the release directory.',
task: () => {
task: async () => {
return releaseTools.prepareRepository( {
outputDirectory: 'release',
rootPackageJson: preparePackageJson()
rootPackageJson: await preparePackageJson()
} );
}
},
Expand Down
4 changes: 2 additions & 2 deletions scripts/utils/preparepackagejson.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
* For licensing, see LICENSE.md or https://ckeditor.com/legal/ckeditor-licensing-options
*/

import packageJson from '../../package.json' with { type: 'json' };
export async function preparePackageJson() {
const { default: packageJson } = await import( '../../package.json', { with: { type: 'json' } } );

export function preparePackageJson() {
if ( packageJson.engines ) {
delete packageJson.engines;
}
Expand Down