Skip to content

Conversation

@pomek
Copy link
Member

@pomek pomek commented Jul 2, 2025

Suggested merge commit message (convention)

Internal: Use dynamic imports to fix issues in the release process. Closes #364.


Additional information

Testing steps

  • I modified the latest changelog version (patch bump).
  • rm -rf release/; yarn release:prepare-packages --branch i/364; cat release/ckeditor5-vue/package.json | grep version
     yarn run v1.22.19
     $ node ./scripts/preparepackages.js --branch i/364
     ✔ Verifying the repository.
     ✔ Updating the `#version` field.
     ✔ Running build command.
     ✔ Creating the `ckeditor5-vue` package in the release directory.
     ✔ Cleaning-up.
     ✔ Commit & tag.
     Done in 4.70s.
       "version": "7.3.1",
    

To clean-up:

git tag -d v7.3.1
git reset --hard HEAD~1

@coveralls
Copy link

Pull Request Test Coverage Report for Build 0a773281-c8d4-4011-a382-ff0cc9728590

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 24d21d4c-ff7a-43fb-9037-a9b25699bdca: 0.0%
Covered Lines: 84
Relevant Lines: 84

💛 - Coveralls

@pomek pomek merged commit 1ed352d into master Jul 2, 2025
7 checks passed
@pomek pomek deleted the i/364 branch July 2, 2025 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

After preparing the release, package.json uses the previous version

4 participants