-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tweak(github/ci): rework #3212
tweak(github/ci): rework #3212
Conversation
e71fbb7
to
99751ce
Compare
Nice PR ! ( supersedes #2900 ) |
Just for the context. I asked author to implement possibility to publish pre-baked Alpine image with all dependencies to our github registry and waiting for that to merge. |
99751ce
to
c3da7b2
Compare
All done🥳 |
Merged |
I dont know if its related to the ci rework but just got that error right now |
If that happens in your fork you need to build Linux Docker image once from "Actions" -> "Build Alpine server building image" -> "Run workflow" |
Same error |
Will fix this (and another oversight) in the next days. Thanks for reporting this! |
Goal of this PR
This PR addresses multiple logic issues in the current PR checkout actions, which have rendered the process non-functional.
How is this PR achieving the goal
GITHUB_REF
, checking out the upstream'smaster
head instead of the correct PR branch head ref. This caused the PR changes to remain unchecked.input_validation
andpost_build
steps, isolating tokens with access from any user-submitted code.Changes have been tested here: https://github.com/tens0rfl0w/fivem/actions/runs/13638653569?pr=20
This PR applies to the following area(s)
Github Actions
Successfully tested on
Game builds: Not applicable
Platforms: GitHub Runners
Checklist
Fixes issues
/