Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak(github/ci): registry auth and lowercase image name #3220

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tens0rfl0w
Copy link
Contributor

Goal of this PR

Addresses two oversights from a previous change (#3212).

How is this PR achieving the goal

  • The repository name and owner name are now converted to lowercase before pushing the builder image to the registry. This ensures compatibility with GHCR, which does not support uppercase characters in image names.
  • Authentication with the container registry is now performed prior to pulling the image, addressing issues related to private access settings.

Note: While these changes have been tested, enterprise organizations may have different configurations when scoping access to private container images. As such, there is no guarantee that this will behave as intended across all environments.

This PR applies to the following area(s)

GitHub CI

Successfully tested on

Game builds: Not applicable

Platforms: Github-hosted Runner

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

Fixes issues

/

@github-actions github-actions bot added the triage Needs a preliminary assessment to determine the urgency and required action label Mar 7, 2025
@prikolium-cfx prikolium-cfx added the ready-to-merge This PR is enqueued for merging label Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR is enqueued for merging triage Needs a preliminary assessment to determine the urgency and required action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants