fix(game/five): fix crash related to river entities

[ook3D]

currently, the game attempts to get a river entity then immediately references it, without checking if the entity is valid, which seems to cause crashes.

GTA5_b3258.exe!sub_1406C1D98 (0x18)
GTA5_b3258.exe!sub_1406DEA90 (0x298)
GTA5_b3258.exe!sub_140777E18 (0x349)
GTA5_b3258.exe!sub_14094CBC0 (0xd5)
GTA5_b3258.exe!sub_14168A14C (0x9c)
GTA5_b3258.exe!sub_14093F53C (0x121)
GTA5_b3258.exe!sub_14095C6AC (0x30)

Goal of this PR

Fix game crash
...

How is this PR achieving the goal

check if the entity is valid first
...

This PR applies to the following area(s)

FiveM
...

Successfully tested on

Game builds: ..

Platforms: Windows, Linux

Checklist

• Code compiles and has been tested successfully.
• Code explains itself well and/or is documented.
• My commit message explains what the changes do and what they are for.
• No extra compilation warnings are added by these changes.

Fixes issues

[DaniGP17]

the reason i have not tested this code is because FiveM does not like it when i replace gta-core-five.dll and i cannot launch the game.

If you tell me what to do, I can try it myself if you want.

[ook3D]

was able to get things working to test, seems to be working properly

[ook3D]

was able to get things working to test, seems to be working properly

i spoke too soon, it seems to be invalidating all river entities currently lol

[ook3D]

interestingly only this section isnt working 🤔

[Gogsi]

For whatever reason, the water entities in that section of the map are duplicated - There are
cs3_05_water07_grp1 and cs3_05_water07_grp2;
cs3_05_water06_grp1 and cs3_05_water06_grp2.
I've raised the grp2 entities here in CodeWalker to show it

I don't know if that's related to the issue though or how it can be fixed

[ook3D]

For whatever reason, the water entities in that section of the map are duplicated - There are cs3_05_water07_grp1 and cs3_05_water07_grp2; cs3_05_water06_grp1 and cs3_05_water06_grp2. I've raised the grp2 entities here in CodeWalker to show it

I don't know if that's related to the issue though or how it can be fixed

Hmm, that's really odd

[ook3D]

For whatever reason, the water entities in that section of the map are duplicated - There are cs3_05_water07_grp1 and cs3_05_water07_grp2; cs3_05_water06_grp1 and cs3_05_water06_grp2. I've raised the grp2 entities here in CodeWalker to show it

I don't know if that's related to the issue though or how it can be fixed

Hmm, that's really odd

wait wtf is happening here?

its not loading in codewalker for me as well?

[ook3D]

i assume this issue isnt related to my PR then if its also present inside codewalker, really weird

[DaniGP17]

i assume this issue isnt related to my PR then if its also present inside codewalker, really weird

Yes, I started looking and found another place where the river does not flow, it's strange that no one noticed before.