Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions packages/comet-marquee/package.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per the convention set out by all the other files in this repo, your file should be at packages/c/comet-marquee.json

Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
{

Check failure on line 1 in packages/comet-marquee/package.json

View workflow job for this annotation

GitHub Actions / robotcdnjs

package path `packages/comet-marquee/package.json` does not match ^packages/([a-z0-9])/([a-zA-Z0-9._-]+).json$
"name": "comet-marquee",
"version": "1.1.15",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cdnjs does not need/support a version property

"description": "A lightweight, smooth-scrolling marquee plugin for modern browsers. Allows continuous horizontal scrolling of content with optional pause on hover or click.",
"main": "dist/comet-marquee.cjs",
"module": "dist/comet-marquee.modern.js",
"unpkg": "dist/comet-marquee.umd.js",
"source": "src/index.js",
"style": "dist/comet-marquee.css",
"scripts": {
"build": "microbundle",
"dev": "microbundle watch"
},
Comment on lines +5 to +13
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cdnjs does not need/support a main/module/unpkg/source/style/scripts property

"keywords": [
"marquee",
"scroll",
"plugin",
"comet"
],
"author": "Oleksandr Vorushylo || Rhaegar259",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cdnjs expects an authors array with each entry being an object that contains a name property

"repository": {
"type": "git",
"url": "https://github.com/OleksandrVorushylo/comet-marquee.git"
},
"license": "MIT",
"devDependencies": {
"microbundle": "^0.15.1",
"rollup-plugin-import-css": "^4.0.2"
},
Comment on lines +26 to +29
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cdnjs does not need/support a devDependencies property

"autoupdate": {
"source": "npm",
"target": "comet-marquee",
"fileMap": [
{
"basePath": "dist",
"files": ["**/*"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not accept configs that contain an open-ended globstar, as it can result in files being added to the CDN that are not needed. Looking at your package on NPM, you should just need *.@(js|mjs|css)?(.map)

}
]
}
}
Loading