-
-
Notifications
You must be signed in to change notification settings - Fork 385
Add comet-marquee w/ npm auto-update #2054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add comet-marquee w/ npm auto-update #2054
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per the convention set out by all the other files in this repo, your file should be at packages/c/comet-marquee.json
| @@ -0,0 +1,40 @@ | |||
| { | |||
| "name": "comet-marquee", | |||
| "version": "1.1.15", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cdnjs does not need/support a version property
| "main": "dist/comet-marquee.cjs", | ||
| "module": "dist/comet-marquee.modern.js", | ||
| "unpkg": "dist/comet-marquee.umd.js", | ||
| "source": "src/index.js", | ||
| "style": "dist/comet-marquee.css", | ||
| "scripts": { | ||
| "build": "microbundle", | ||
| "dev": "microbundle watch" | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cdnjs does not need/support a main/module/unpkg/source/style/scripts property
| "plugin", | ||
| "comet" | ||
| ], | ||
| "author": "Oleksandr Vorushylo || Rhaegar259", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cdnjs expects an authors array with each entry being an object that contains a name property
| "devDependencies": { | ||
| "microbundle": "^0.15.1", | ||
| "rollup-plugin-import-css": "^4.0.2" | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cdnjs does not need/support a devDependencies property
| "fileMap": [ | ||
| { | ||
| "basePath": "dist", | ||
| "files": ["**/*"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not accept configs that contain an open-ended globstar, as it can result in files being added to the CDN that are not needed. Looking at your package on NPM, you should just need *.@(js|mjs|css)?(.map)
|
No progress, closing. |
https://www.npmjs.com/package/comet-marquee