Skip to content

Conversation

@OleksandrVorushylo
Copy link

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per the convention set out by all the other files in this repo, your file should be at packages/c/comet-marquee.json

@@ -0,0 +1,40 @@
{
"name": "comet-marquee",
"version": "1.1.15",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cdnjs does not need/support a version property

Comment on lines +5 to +13
"main": "dist/comet-marquee.cjs",
"module": "dist/comet-marquee.modern.js",
"unpkg": "dist/comet-marquee.umd.js",
"source": "src/index.js",
"style": "dist/comet-marquee.css",
"scripts": {
"build": "microbundle",
"dev": "microbundle watch"
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cdnjs does not need/support a main/module/unpkg/source/style/scripts property

"plugin",
"comet"
],
"author": "Oleksandr Vorushylo || Rhaegar259",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cdnjs expects an authors array with each entry being an object that contains a name property

Comment on lines +26 to +29
"devDependencies": {
"microbundle": "^0.15.1",
"rollup-plugin-import-css": "^4.0.2"
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cdnjs does not need/support a devDependencies property

"fileMap": [
{
"basePath": "dist",
"files": ["**/*"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not accept configs that contain an open-ended globstar, as it can result in files being added to the CDN that are not needed. Looking at your package on NPM, you should just need *.@(js|mjs|css)?(.map)

@MattIPv4 MattIPv4 changed the title Add comet-marquee package for cdnjs autoupdate Add comet-marquee w/ npm auto-update Oct 3, 2025
@MattIPv4
Copy link
Member

MattIPv4 commented Nov 3, 2025

No progress, closing.

@MattIPv4 MattIPv4 closed this Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants