Add tf2_eigen dependency for PCL recorder. #645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
1 similar comment
|
+1 |
Dragonrock
approved these changes
Jun 24, 2023
|
+1 |
oliver-schumann
left a comment
oliver-schumann
left a comment
There was a problem hiding this comment.
+1
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @JAP3TH)
oliver-schumann
approved these changes
Nov 17, 2023
DaniCarias
approved these changes
Mar 21, 2024
DaniCarias
left a comment
DaniCarias
left a comment
There was a problem hiding this comment.
Works for me in Ubuntu 22.04 ROS Humble
Fillipko
approved these changes
Nov 7, 2024
|
+1 |
|
Can we please have this PR merged? On ROS2 Humble there's still the include error for Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To build carla_ros_bridge in ROS2, additionally the
tf2_eigenlibrary is required.This change is