New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: SelectableTileGroup #439

Open

ispyinternet wants to merge 57 commits into carbon-design-system:master from ispyinternet:master

Contributor

ispyinternet commented Nov 30, 2020

No description provided.

ispyinternet added 8 commits

November 27, 2020 01:24


          Add padding prop to Grid component

9af756b


          Fix file name

06ecbe7


          Build lib

585341d


          Merge master

47f6292


          Typo

f17b35d


          Move DataTableSkelton 3119restProps to container

3c59a6c


          Merge branch 'master' of github.com:IBM/carbon-components-svelte

36987b2


          Merge branch 'master' of github.com:IBM/carbon-components-svelte

626fd99

ispyinternet requested a review from metonym as a code owner

November 30, 2020 20:23

vercel bot commented Nov 30, 2020 •

edited

Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-svelte/carbon-components-svelte/plux0963q
✅ Preview: https://carbon-components-svelte-git-master.carbon-svelte.vercel.app

vercel bot had a problem deploying to Preview

November 30, 2020 20:23

Failure

metonym requested changes

View reviewed changes

src/Tile/TileGroup.svelte Outdated Show resolved Hide resolved

src/Tile/RadioTile.svelte Outdated Show resolved Hide resolved

src/Tile/RadioTile.svelte Outdated Show resolved Hide resolved

src/DataTableSkeleton/DataTableSkeleton.svelte Outdated Show resolved Hide resolved

src/Tile/RadioTile.svelte Outdated Show resolved Hide resolved

Collaborator

metonym commented Nov 30, 2020

In addition to passing the CI/deploy preview, could you remove the committed package-lock.json files?


          WIP: SelectableTileGroup

fe5c571

ispyinternet force-pushed the master branch from 361d2df to fe5c571 Compare

November 30, 2020 21:06

vercel bot had a problem deploying to Preview

November 30, 2020 21:06

Failure

Contributor Author

ispyinternet commented Nov 30, 2020

In addition to passing the CI/deploy preview, could you remove the committed package-lock.json files?

Should I update .gitignore?

I also inadvertantly added palimpsest, should I add this to gitignore?

Contributor Author

ispyinternet commented Nov 30, 2020 •

edited

Loading

BTW, you said in the issue comments to use selectedItem selectedItems which also is breaking? Wasn't sure if you realised?

I'm leaning towards keeping them separate. Preserve the TileGroup component but add two new ones dedicated to the SelectableTile, RadioTile respectively:

SelectableTileGroup – bind:selectedValues
RadioTileGroup – bind:selectedValue

vercel bot had a problem deploying to Preview

November 30, 2020 21:32

Failure

Collaborator

metonym commented Nov 30, 2020 •

edited

Loading

How about creating separate PRs that address the issues individually?

DataTableSkeleton Inconsistent use of rest props with DataTable and DataTableSkeleton #423
new SelectableTileGroup component RadioTile support 'multiple' prop? #428
new RadioTileGroup component

ispyinternet force-pushed the master branch from 4094765 to c2f53d8 Compare

November 30, 2020 21:33

vercel bot had a problem deploying to Preview

November 30, 2020 21:33

Failure

Collaborator

metonym commented Nov 30, 2020

BTW, you said in the issue comments to use selectedItem selectedItems which also is breaking? Wasn't sure if you realised?

selectedValue and selectedValues would be new props if SelectableTileGroup and RadioTileGroup components are introduced.


          Some fixes

184c3d9

ispyinternet force-pushed the master branch from c2f53d8 to 184c3d9 Compare

November 30, 2020 21:39

vercel bot had a problem deploying to Preview

November 30, 2020 21:39

Failure


          Some fixes

5f5293a

vercel bot had a problem deploying to Preview

November 30, 2020 21:44

Failure

metonym reviewed

View reviewed changes

src/Tile/SelectableTileGroup.svelte Outdated Show resolved Hide resolved


          Some fixes

94f5965


          try to fix reactivity

52240c6

vercel bot deployed to Preview

December 10, 2020 19:28

View deployment


          try to fix reactivity

e6fdda5

vercel bot deployed to Preview

December 10, 2020 19:45

View deployment


          try to fix reactivity

8431b58

vercel bot deployed to Preview

December 10, 2020 20:01

View deployment


          try to fix reactivity

172f54e

vercel bot deployed to Preview

December 10, 2020 20:37

View deployment


          try to fix reactivity

7b3144f

vercel bot deployed to Preview

December 10, 2020 20:48

View deployment


          try to fix reactivity

ac99f8f

vercel bot deployed to Preview

December 10, 2020 20:59

View deployment


          try to fix reactivity

cbdf10d

vercel bot deployed to Preview

December 10, 2020 21:14

View deployment


          try to fix reactivity

7373aa3

vercel bot deployed to Preview

December 10, 2020 21:30

View deployment

Contributor Author

ispyinternet commented Dec 10, 2020 •

edited

Loading

@metonym I have to admit I'm stumped on the last example. I can't get an atomic update of the store. Basically, I'm reasoning that as the control updates the each loop, when the first item updates, the store updates, which passes an update back down to the children - it will only reset one item at a time. I attempted to use #key but that doesn't fix it:

https://carbon-components-svelte-plux0963q.vercel.app/framed/SelectableTile/SelectableTileReactive

lalilaloe mentioned this pull request

Allow disable attribute for SelectableTile #539

Closed

ibm-ci-bot commented Jul 16, 2021

@ispyinternet: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

8 similar comments

ibm-ci-bot commented Jul 17, 2021

@ispyinternet: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ibm-ci-bot commented Jul 19, 2021

@ispyinternet: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ibm-ci-bot commented Jul 20, 2021

@ispyinternet: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ibm-ci-bot commented Jul 21, 2021

@ispyinternet: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ibm-ci-bot commented Jul 24, 2021

@ispyinternet: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ibm-ci-bot commented Jul 25, 2021

@ispyinternet: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ibm-ci-bot commented Jul 27, 2021

@ispyinternet: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ibm-ci-bot commented Jul 28, 2021

@ispyinternet: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

metonym force-pushed the master branch 2 times, most recently from e7485c4 to 417102d Compare

November 8, 2023 03:27

metonym force-pushed the master branch from 1a0a744 to 107b77d Compare

December 25, 2024 18:15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet