Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disable attribute for SelectableTile #539

Closed
wants to merge 1 commit into from
Closed

Allow disable attribute for SelectableTile #539

wants to merge 1 commit into from

Conversation

lalilaloe
Copy link

I have seen #439 but tiles should be able to be disabled per tile. If for example one item in the list of selectable tiles is not available.

@lalilaloe lalilaloe requested a review from josefaidt as a code owner February 26, 2021 12:44
@vercel
Copy link

vercel bot commented Feb 26, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-svelte/carbon-components-svelte/BtRY7zsyhamYgy91WGuwgvjqMVCj
✅ Preview: https://carbon-compone-git-fork-lalilaloe-feature-disable-select-6673b1.vercel.app

@metonym
Copy link
Collaborator

metonym commented Mar 20, 2021

I agree. However, the issue is that there is no styling for the disabled state.

I believe this will be supported in Carbon v10.32 though.

Refs: carbon-design-system/carbon@91b6c05

@metonym metonym closed this in #588 Apr 2, 2021
metonym added a commit that referenced this pull request Apr 2, 2021
* feat(code-snippet): add copy functionality

- docs: add custom feedback copy text example

* feat(tile): support disabled state for SelectableTile, RadioTile

Closes #539

* build(rollup): add clipboard-copy to globals

* feat(copy-button): add copy functionality

* feat(content-switcher): deprecate the light prop

- docs: remove the light variant example

* fix(toolbar-search): remove outer div

* feat(search): add searchClass prop

* fix(composed-modal): set hasScrollingContent class on ModalBody

* docs(data-table): add expandable size examples

* feat(tooltip): add TooltipFooter component

* fix(time-picker): correctly display invalidText

* feat(breadcrumb): support overflow menu

* feat(multi-select): export inputRef prop

* chore(deps-dev): upgrade carbon-components to v10.32.0

* feat(form): add noMargin prop to FormGroup

* docs(tooltip): document TooltipFooter

* feat(context-menu): support danger kind for ContextMenuOption

* feat(data-table): support rendering empty table header in skeleton

* refactor(types): use shorter import path in DataTableSkeleton

* feat(data-table): allow sorting to be disabled for a specific header

* docs(data-table): update example to desort the Protocol header

As an example, it makes more sense because all the values ("http") are the same.

* fix(context-menu): set initial y offset of context menu based on window height #577

* fix(context-menu): render submenu based on viewport constraints #577
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants