-
Notifications
You must be signed in to change notification settings - Fork 1
fix: adapt tests for Windows #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
So, please address #23 (comment) first. After merging #23, I'll take a look at this more carefully. Also, please change the target branch to A quick thought is that I think it's still better to mock the |
7261521 to
0448c72
Compare
9b84f5a to
a068a7a
Compare
If you look closely, I just extracted the test The Github runner in Instead, I added a direct test |
a068a7a to
d5f00b8
Compare
d5f00b8 to
2f7aff1
Compare
c0rychu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some comments
Co-authored-by: Cory Chu <[email protected]>
|
@cursor review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on December 12
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
7ba13f4 to
c86769a
Compare
|
@cursor review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adapt all tests for Windows, no skipping needed.
Set
default_pathusing builtinPath.home()instead of~.Address #22
Note
Adapts tests for Windows (hashing, tilde resolution, symlink/junction behavior), adds path_utils tests, and updates get_uvlink_dir to default to Path.home()/.local/share.
hash_path("/")expectation OS-aware viais_windows(); add tilde path resolution test withoutmonkeypatch; refine assertions (as_posix()); add symlink resolution; add metadata roundtrip andsanitize_venv_typechecks; addget_uvlink_dirtests usingXDG_DATA_HOME.ls, assert exact cache location string:"Cache Location: {cache_dir}".create_symlink, Windowscreate_windows_junction(with skip on non-Windows), and invalid target error.get_uvlink_dirto default base toPath.home() / ".local" / "share"instead of a"~"string.Written by Cursor Bugbot for commit c86769a. This will update automatically on new commits. Configure here.