-
Notifications
You must be signed in to change notification settings - Fork 0
Closed
Labels
Description
Tests with tilde (~)
These tests involve tilde ~ will fail on Windows simply because the symbol is not recognized by Windows.
Suggestion
Put them in a separate tests that are skipped if running on Windows.
test_hash_path
This test fails on Windows (or maybe different environment, different Python version, etc.), the hardcoded value is not always the same.
Suggestion
The hardcoded value is flaky and not really deterministic, we should remove it. What's important is to test the behavior of the hash function, which is producing the same hash with the same input.
uvlink/cache in path string
This test and this test fail on Windows due to the path string is resolve differently, uvlink/cache would become uvlink//cache.
Suggestion
Replace:
assert "Cache Location:" in result.stdout
assert "uvlink/cache" in result.stdout
with:
assert f"Cache Location: {cache_dir}" in result.stdout
Or just remove the assert for uvlink/cache entirely.