Skip to content

Create the output directory if it does not exist (#118) #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chikoski wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Create the output directory if it does not exist (#118) #141

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19c02e2
Change to create the output directory if it does not exist (#118)
chikoski Dec 29, 2024
4f00abf
Switch file system API from std::fs to tokio::fs to
chikoski Jan 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions crates/wkg/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use std::{io::Seek, path::PathBuf};
use std::{fs, io::Seek, path::PathBuf};
Copy link
Collaborator

@thomastaylor312 thomastaylor312 Dec 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please swap out to use tokio::fs since the function is an async one?

Copy link
Author

@chikoski chikoski Jan 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for my delayed response. Updated the code as suggest.

Note: the CI is failed as wasm32-wasi is not available now.


use anyhow::{ensure, Context};
use clap::{Args, Parser, Subcommand, ValueEnum};
Expand Down Expand Up @@ -312,7 +312,12 @@ impl GetArgs {

let output_trailing_slash = self.output.as_os_str().to_string_lossy().ends_with('/');
let parent_dir = if output_trailing_slash {
self.output.as_path()
let parent_dir = self.output.as_path();
if !fs::exists(parent_dir)? {
fs::create_dir_all(parent_dir)
.context("Failed to create output dir")?
}
parent_dir
} else {
self.output
.parent()
Expand Down
Loading