Create the output directory if it does not exist (#118) #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomastaylor312
requested changes
Dec 30, 2024
Collaborator
thomastaylor312
left a comment
thomastaylor312
left a comment
There was a problem hiding this comment.
Thanks for adding this! Just one small change needed
crates/wkg/src/main.rs
Outdated
| @@ -1,4 +1,4 @@ | |||
| use std::{io::Seek, path::PathBuf}; | |||
| use std::{fs, io::Seek, path::PathBuf}; | |||
Collaborator
There was a problem hiding this comment.
Can you please swap out to use tokio::fs since the function is an async one?
Author
There was a problem hiding this comment.
Apologies for my delayed response. Updated the code as suggest.
Note: the CI is failed as wasm32-wasi is not available now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a fix for issue #118. With this fix, the
getcommand creates the directory specified by the-ooption if the specified directory does not exist.For example, the following command creates the
witdirectory and saves thewasi:[email protected]in it: