Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library fixes for teensy 3.1 and latest Teensyduino #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

soerup
Copy link

@soerup soerup commented May 9, 2015

I needed to make these changes to work with the Teensyduino 1.22 and Teensy 3.1

@btmcmahan
Copy link
Owner

You're right, I've seen that myself. Other than that, did this work okay for you?

@soerup
Copy link
Author

soerup commented May 9, 2015

It did, but I have only tested Slave mode so far, as that was what I needed for my application.

I did an 8bit slave, mode 0, 1 mhz clock (controlled by master) and it looked stable. I used your demo code as the basis.

@soerup
Copy link
Author

soerup commented May 13, 2015

Followup - I have some issues with rxtx8 which messes up completely for my application. I'm looking into understanding the underlying issues. [deleted wrong question]

@trentdye
Copy link

@soerup It wouldn't hurt to update the example code with these changes. Examples reference CTAR0 and should instead reference CTAR_0; but it's a quick fix to replace.

Could you explain why you changed CTAR0 and CTAR1 to CTAR_0 and CTAR_1?

@soerup
Copy link
Author

soerup commented Jul 24, 2015

Changes are made to avoid name clashes in TeensyDuino 1.22 with Teensy 3.1.

And you are right it wouldn't hurt to update the examples. I did not use thus, I did not notice they were broken. Feel free to submit patch. Should be simple compile fixing.

@trentdye
Copy link

@soerup Thanks for the info!

@brianc118 brianc118 mentioned this pull request Jul 26, 2015
@gunderson
Copy link

+1

Had to use @soerup 's repo with this PR to get it to compile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants