Skip to content

Conversation

@wydengyre
Copy link
Contributor

@wydengyre wydengyre commented Oct 29, 2025

Change Description

Ensure that the dial phase of rpcclient's HTTP posts respects the http.Client's Timeout. It was instead falling back to the OS settings.

Steps to Test

This is a bit challenging to test, as it requires simulating a very laggy dial. Not sure the juice is worth the squeeze.

Pull Request Checklist

Testing

  • Your PR passes all CI checks.
  • Tests covering the positive and negative (error paths) are included.
  • Bug fixes contain tests triggering the bug to prevent regressions.

Code Style and Documentation

📝 Please see our Contribution Guidelines for further guidance.

Ensure that the dial phase of rpcclient's HTTP posts respects the http.Client's Timeout. It was instead falling back to the OS settings.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 18913980728

Details

  • 1 of 4 (25.0%) changed or added relevant lines in 1 file are covered.
  • 16 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.09%) to 54.954%

Changes Missing Coverage Covered Lines Changed/Added Lines %
rpcclient/infrastructure.go 1 4 25.0%
Files with Coverage Reduction New Missed Lines %
rpcclient/infrastructure.go 16 47.8%
Totals Coverage Status
Change from base Build 18858421588: 0.09%
Covered Lines: 31199
Relevant Lines: 56773

💛 - Coveralls

@wydengyre
Copy link
Contributor Author

Note, it looks like the underlying issue here was introduced in https://github.com/btcsuite/btcd/pull/2168/files

Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐩

@Roasbeef Roasbeef merged commit 9ff0780 into btcsuite:master Nov 6, 2025
3 checks passed
@wydengyre wydengyre deleted the btc-client-correct-dialcontext branch November 6, 2025 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants