Skip to content

Conversation

@wydengyre
Copy link
Contributor

@wydengyre wydengyre commented Oct 30, 2025

Change Description

Modify the rpcclient http POST call to ensure that a shutdown immediately interrupts in-flight requests, which otherwise would have to wait until timeout.

This PR includes the change in #2450 as it is necessary to ensure interruption during Dial.

Steps to Test

The test suite has an added test to ensure this works.

Pull Request Checklist

Testing

  • Your PR passes all CI checks.
  • Tests covering the positive and negative (error paths) are included.
  • Bug fixes contain tests triggering the bug to prevent regressions.

Code Style and Documentation

📝 Please see our Contribution Guidelines for further guidance.

@coveralls
Copy link

coveralls commented Oct 30, 2025

Pull Request Test Coverage Report for Build 19126705309

Details

  • 21 of 28 (75.0%) changed or added relevant lines in 1 file are covered.
  • 93 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.006%) to 54.967%

Changes Missing Coverage Covered Lines Changed/Added Lines %
rpcclient/infrastructure.go 21 28 75.0%
Files with Coverage Reduction New Missed Lines %
mempool/mempool.go 1 66.56%
btcutil/gcs/gcs.go 2 81.55%
connmgr/connmanager.go 2 83.9%
rpcclient/infrastructure.go 88 48.35%
Totals Coverage Status
Change from base Build 19121431262: 0.006%
Covered Lines: 31216
Relevant Lines: 56790

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants