Skip to content

[v2] fix: handle page close events and avoid errors on closed targets #1497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shrey150 wants to merge 2 commits into
base: v2
Choose a base branch
from
+54 −9
Open

[v2] fix: handle page close events and avoid errors on closed targets #1497

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e2e5ac
fix: handle page close events and avoid errors on closed targets
shrey150 Jan 5, 2026
4eb04e3
Fix duplicate close handler
shrey150 Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 63 additions & 6 deletions lib/StagehandContext.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,23 +179,80 @@ export class StagehandContext {
}

private async handleNewPlaywrightPage(pwPage: PlaywrightPage): Promise<void> {
let stagehandPage = this.pageMap.get(pwPage);
if (!stagehandPage) {
stagehandPage = await this.createStagehandPage(pwPage);
if (pwPage.isClosed()) return;

pwPage.once("close", () => {
const shPage = this.pageMap.get(pwPage);
if (shPage && this.activeStagehandPage === shPage) {
const openPages = this.intContext.pages();
for (const p of openPages) {
const sp = this.pageMap.get(p);
if (sp && sp !== shPage) {
this.setActivePage(sp);
break;
}
}
}
});

try {
let stagehandPage = this.pageMap.get(pwPage);
if (!stagehandPage) {
stagehandPage = await this.createStagehandPage(pwPage);
}
this.setActivePage(stagehandPage);
} catch (err) {
const msg = (err as Error).message ?? "";
if (
msg.includes("No target with given id") ||
msg.includes("Target closed") ||
msg.includes("Target page, context or browser has been closed")
) {
return;
}
throw err;
}
this.setActivePage(stagehandPage);
}

private async attachFrameNavigatedListener(
pwPage: PlaywrightPage,
): Promise<void> {
const shPage = this.pageMap.get(pwPage);
if (!shPage) return;
const session: CDPSession = await this.intContext.newCDPSession(pwPage);
await session.send("Page.enable");

if (pwPage.isClosed()) return;

let session: CDPSession;
try {
session = await this.intContext.newCDPSession(pwPage);
await session.send("Page.enable");
} catch (err) {
const msg = (err as Error).message ?? "";
if (
msg.includes("No target with given id") ||
msg.includes("Target closed") ||
msg.includes("Target page, context or browser has been closed")
) {
return;
}
throw err;
}

pwPage.once("close", () => {
if (shPage.frameId) this.unregisterFrameId(shPage.frameId);

if (this.activeStagehandPage === shPage) {
const openPages = this.intContext.pages();
if (openPages.length > 0) {
for (const p of openPages) {
const sp = this.pageMap.get(p);
if (sp && sp !== shPage) {
this.setActivePage(sp);
break;
}
}
}
}
});

session.on(
Expand Down
Loading