Skip to content

[v2] fix: handle page close events and avoid errors on closed targets #1497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shrey150 wants to merge 2 commits into
base: v2
Choose a base branch
from
Open

[v2] fix: handle page close events and avoid errors on closed targets #1497

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e2e5ac
fix: handle page close events and avoid errors on closed targets
shrey150 Jan 5, 2026
4eb04e3
Fix duplicate close handler
shrey150 Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 54 additions & 9 deletions lib/StagehandContext.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,24 +179,69 @@ export class StagehandContext {
}

private async handleNewPlaywrightPage(pwPage: PlaywrightPage): Promise<void> {
let stagehandPage = this.pageMap.get(pwPage);
if (!stagehandPage) {
stagehandPage = await this.createStagehandPage(pwPage);
if (pwPage.isClosed()) return;

// Only register close handler once per page
if (!this.pageMap.has(pwPage)) {
pwPage.once("close", () => {
const shPage = this.pageMap.get(pwPage);
if (shPage) {
if (shPage.frameId) this.unregisterFrameId(shPage.frameId);
if (this.activeStagehandPage === shPage) {
for (const p of this.intContext.pages()) {
const sp = this.pageMap.get(p);
if (sp && sp !== shPage) {
this.setActivePage(sp);
break;
}
}
Comment on lines +191 to +197
Copy link
Contributor

@greptile-apps greptile-apps bot Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: check that candidate page p is not closed before setting as active

Suggested change
for (const p of this.intContext.pages()) {
const sp = this.pageMap.get(p);
if (sp && sp !== shPage) {
this.setActivePage(sp);
break;
}
}
for (const p of this.intContext.pages()) {
if (!p.isClosed()) {
const sp = this.pageMap.get(p);
if (sp && sp !== shPage) {
this.setActivePage(sp);
break;
}
}
}
Prompt To Fix With AI 
This is a comment left during a code review.
Path: lib/StagehandContext.ts
Line: 191:197

Comment:
**style:** check that candidate page `p` is not closed before setting as active

```suggestion
            for (const p of this.intContext.pages()) {
              if (!p.isClosed()) {
                const sp = this.pageMap.get(p);
                if (sp && sp !== shPage) {
                  this.setActivePage(sp);
                  break;
                }
              }
            }
```

How can I resolve this? If you propose a fix, please make it concise.

}
}
});
}

try {
let stagehandPage = this.pageMap.get(pwPage);
if (!stagehandPage) {
stagehandPage = await this.createStagehandPage(pwPage);
}
this.setActivePage(stagehandPage);
} catch (err) {
const msg = (err as Error).message ?? "";
if (
msg.includes("No target with given id") ||
msg.includes("Target closed") ||
msg.includes("Target page, context or browser has been closed")
) {
return;
}
throw err;
}
this.setActivePage(stagehandPage);
}

private async attachFrameNavigatedListener(
pwPage: PlaywrightPage,
): Promise<void> {
const shPage = this.pageMap.get(pwPage);
if (!shPage) return;
const session: CDPSession = await this.intContext.newCDPSession(pwPage);
await session.send("Page.enable");

pwPage.once("close", () => {
if (shPage.frameId) this.unregisterFrameId(shPage.frameId);
});
if (pwPage.isClosed()) return;

let session: CDPSession;
try {
session = await this.intContext.newCDPSession(pwPage);
await session.send("Page.enable");
} catch (err) {
const msg = (err as Error).message ?? "";
if (
msg.includes("No target with given id") ||
msg.includes("Target closed") ||
msg.includes("Target page, context or browser has been closed")
) {
return;
}
throw err;
}

session.on(
"Page.frameNavigated",
Expand Down
Loading