Small tweaking here and there #337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaudiger
force-pushed
the
small-tweaking
branch
from
556cfed to
7a6bcd8
Compare
Signed-off-by: Jérémy Audiger <[email protected]>
Signed-off-by: Jérémy Audiger <[email protected]>
…hrough a variable Signed-off-by: Jérémy Audiger <[email protected]>
Signed-off-by: Jérémy Audiger <[email protected]>
…ng an explicit return Signed-off-by: Jérémy Audiger <[email protected]>
jaudiger
force-pushed
the
small-tweaking
branch
from
7a6bcd8 to
7f42b0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All these modifications were done while working on better format support with multiples packages as discussed on Discord.
This PR has no user facing impact, and a few changes were even discovered by Clippy while reworking a few part of the code (but these reworks are not part of this PR, I'll open a dedicated PR for that, later).