-
Notifications
You must be signed in to change notification settings - Fork 7
Update efficiency of format command when working with multiple projects #338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I tested locally with this command in brioche-packages
:
echo ./packages/* | xargs printf -- '-p %s\n' | time xargs brioche fmt
...and it didn't seem to speed up or slow down things noticeably (~7 seconds before and after this change). But the end result has a better output in my opinion, since it now shows all the files at once instead of separating them by project, which I personally prefer!
…le projects Signed-off-by: Jérémy Audiger <[email protected]>
Signed-off-by: Jérémy Audiger <[email protected]>
8260a38
to
522bb7a
Compare
@kylewlacy I just pushed a rebase on top of main branch to resolve merge conflicts due to similar commits between this PR and main.
I wanted to also get some figures from the CI on brioche-packages to compare. As for now it takes around 15s to check the formatting of files of each package, one by one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Based on top of #337
This PR is very similar to #255, it adapts the format command this time to be more efficient when working with multiple projects.