-
Notifications
You must be signed in to change notification settings - Fork 269
callbacks attempted #287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Jasbriana
wants to merge
2
commits into
bloominstituteoftechnology:master
Choose a base branch
from
Jasbriana:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
callbacks attempted #287
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,17 +5,66 @@ const counter = () => { | |
| // Example: const newCounter = counter(); | ||
| // newCounter(); // 1 | ||
| // newCounter(); // 2 | ||
| }; | ||
| let count = 0; | ||
| const newCounter = () => { | ||
| count++; | ||
| return count; | ||
| }; | ||
| return newCounter; | ||
| }; | ||
|
|
||
|
|
||
|
|
||
|
|
||
| const counterFactory = () => { | ||
| // Return an object that has two methods called `increment` and `decrement`. | ||
| // `increment` should increment a counter variable in closure scope and return it. | ||
| // `decrement` should decrement the counter variable and return it. | ||
| let count = 0; | ||
| return { | ||
| increment () { | ||
| count ++; | ||
| return count | ||
| } | ||
| decrement( { | ||
| count++; | ||
| return 0 - count; | ||
| }) | ||
| } | ||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
| let nums = 0; | ||
| let newObject = {}; | ||
| return newObject = { | ||
| increment: () => { | ||
| return nums += 1; | ||
| }, | ||
| decrement: () => { | ||
| return nums -= 1; | ||
| }, | ||
|
|
||
|
|
||
|
|
||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure why you have two here... |
||
|
|
||
| }; | ||
|
|
||
| const limitFunctionCallCount = (cb, n) => { | ||
| // Should return a function that invokes `cb`. | ||
| // The returned function should only allow `cb` to be invoked `n` times. | ||
| let count = n; | ||
| return (...args) => { | ||
| if (count > 0) { | ||
| --count; | ||
| return cb(...args); | ||
| } | ||
| return null; | ||
|
|
||
|
|
||
|
|
||
|
|
||
| }; | ||
|
|
||
| /* STRETCH PROBLEM */ | ||
|
|
@@ -27,6 +76,17 @@ const cacheFunction = (cb) => { | |
| // If the returned function is invoked with arguments that it has already seen | ||
| // then it should return the cached result and not invoke `cb` again. | ||
| // `cb` should only ever be invoked once for a given set of arguments. | ||
| function cacheFunction(cb) { | ||
| return function (number) { | ||
| number + number; | ||
| return cb(number); | ||
| } | ||
| } | ||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
| }; | ||
|
|
||
| /* eslint-enable no-unused-vars */ | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
watch out for your naming, it has to be consistent and you usually want to use camelCase.
so for instance NewArray should be newArray (like it is in your for-loop).
Then you want to return the newArray outside of the loop. If the return statement is inside the for-loop then the for-loop will stop looping!