callbacks attempted #287
Open
callbacks attempted #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sulemc
reviewed
Mar 22, 2018
| for (let i = 0; i< elements.length; i++) { | ||
| newArray.push(cb(elements[i])) | ||
| return Array; | ||
| } |
There was a problem hiding this comment.
watch out for your naming, it has to be consistent and you usually want to use camelCase.
so for instance NewArray should be newArray (like it is in your for-loop).
Then you want to return the newArray outside of the loop. If the return statement is inside the for-loop then the for-loop will stop looping!
sulemc
reviewed
Mar 22, 2018
| }, | ||
|
|
||
|
|
||
|
|
|
Let me know if you have any questions! You can use the code you have here as a reference for future assignments! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.