Feature: Nomenclature cleanup #2151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kage type are bounded
…`for` to make the function of the loop more obvious
…ile` to `for` to make the function of the loop more obvious
…ile` to `for` to make the function of the loop more obvious
…f nomenclature mistakes
…rn memory write primitive and the Cortex-M header macros
…n place of a custom private structure for space and complexity savings
…t and save the space consumed
…e()` using the target Flash API guarantees
…e()` using the target Flash API guarantees
…ormation gathering routines
esden
reviewed
Oct 4, 2025
Member
esden
left a comment
esden
left a comment
There was a problem hiding this comment.
I have only two very minor questions. Otherwise it all looks good to me and after the questions are answered we can merge this. :)
…writes to use the helper macros to better document what's going on
esden
approved these changes
Oct 4, 2025
Member
esden
left a comment
esden
left a comment
There was a problem hiding this comment.
LGTM, thanks for putting this together! :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description
In this PR we clean up nomenclature across the code base and significant clean up and unify structure and layout of particularly target support. This concludes the long-running refactoring campaign to modernise and unify the code base that was started back in v1.8.
This brings with it a fix for #2148 removing a diagnostic that some users we relying on for writes, and target Flash API modernisation for several targets' Flash code, thus reducing Flash usage for that support.
Due to the sheer number of commits in this PR, we are opting to call it complete where it is and resume cleanup in the platforms and BMD core in a new PR to help manage review and load.
Your checklist for this pull request
Closing issues