Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) Multi platform abstraction tweaks #1195

Closed
Closed
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 78 additions & 0 deletions bitsandbytes/backends/_subinterfaces.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,78 @@
from abc import ABC, abstractmethod


class RequiredUtilities(ABC):
@abstractmethod
def check_matmul():
raise NotImplementedError


class FourBitMatmul(ABC):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something to think about here is that for the nested quantization, the interface for KBitQuantization is needed (quantize_blockwise/dequantize_blockwise)

@abstractmethod
def quantize_4bit():
raise NotImplementedError

@abstractmethod
def dequantize_4bit():
raise NotImplementedError

@abstractmethod
def gemv_4bit():
raise NotImplementedError


class EightBitMatMul(ABC):
@abstractmethod
def mm_dequant():
raise NotImplementedError

@abstractmethod
def double_quant():
raise NotImplementedError

@abstractmethod
def extract_outliers():
raise NotImplementedError

@abstractmethod
def igemmlt():
raise NotImplementedError

@abstractmethod
def get_col_row_absmax():
raise NotImplementedError


class KBitQuantization(ABC):
@abstractmethod
def quantize_blockwise():
raise NotImplementedError

@abstractmethod
def dequantize_blockwise():
raise NotImplementedError

@abstractmethod
def estimate_quantiles():
raise NotImplementedError

@abstractmethod
def create_quant_map():
raise NotImplementedError


class EightBitOptimizer(ABC):
@abstractmethod
def optimizer_update_32bit():
"""Needed only for testing purposes."""
raise NotImplementedError

@abstractmethod
def optimizer_update_8bit_blockwise():
raise NotImplementedError


class CompleteBnbAlgorithmsInterface(
RequiredUtilities, FourBitMatmul, EightBitMatMul, KBitQuantization, EightBitOptimizer
):
pass
18 changes: 0 additions & 18 deletions bitsandbytes/cextension.py
Original file line number Diff line number Diff line change
@@ -1,21 +1,3 @@
"""
extract factors the build is dependent on:
[X] compute capability
[ ] TODO: Q - What if we have multiple GPUs of different makes?
- CUDA version
- Software:
- CPU-only: only CPU quantization functions (no optimizer, no matrix multiple)
- CuBLAS-LT: full-build 8-bit optimizer
- no CuBLAS-LT: no 8-bit matrix multiplication (`nomatmul`)

evaluation:
- if paths faulty, return meaningful error
- else:
- determine CUDA version
- determine capabilities
- based on that set the default path
"""

import ctypes as ct
import logging
import os
Expand Down
Loading