-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(WIP) Multi platform abstraction tweaks #1195
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
0ec54fe
delete obsolete comment
Titus-von-Koeller 4540300
Merge remote-tracking branch 'upstream/multi-backend-refactor' into m…
Titus-von-Koeller 64eff52
sketch out modular sub-interfaces
Titus-von-Koeller 7772fa3
doc-builder image had been changed, need to revert to old one due to …
Titus-von-Koeller 6efe03c
Merge remote-tracking branch 'upstream/main' into multi-platform-tweaks
Titus-von-Koeller File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,78 @@ | ||
from abc import ABC, abstractmethod | ||
|
||
|
||
class RequiredUtilities(ABC): | ||
@abstractmethod | ||
def check_matmul(): | ||
raise NotImplementedError | ||
|
||
|
||
class FourBitMatmul(ABC): | ||
@abstractmethod | ||
def quantize_4bit(): | ||
raise NotImplementedError | ||
|
||
@abstractmethod | ||
def dequantize_4bit(): | ||
raise NotImplementedError | ||
|
||
@abstractmethod | ||
def gemv_4bit(): | ||
raise NotImplementedError | ||
|
||
|
||
class EightBitMatMul(ABC): | ||
@abstractmethod | ||
def mm_dequant(): | ||
raise NotImplementedError | ||
|
||
@abstractmethod | ||
def double_quant(): | ||
raise NotImplementedError | ||
|
||
@abstractmethod | ||
def extract_outliers(): | ||
raise NotImplementedError | ||
|
||
@abstractmethod | ||
def igemmlt(): | ||
raise NotImplementedError | ||
|
||
@abstractmethod | ||
def get_col_row_absmax(): | ||
raise NotImplementedError | ||
|
||
|
||
class KBitQuantization(ABC): | ||
@abstractmethod | ||
def quantize_blockwise(): | ||
raise NotImplementedError | ||
|
||
@abstractmethod | ||
def dequantize_blockwise(): | ||
raise NotImplementedError | ||
|
||
@abstractmethod | ||
def estimate_quantiles(): | ||
raise NotImplementedError | ||
|
||
@abstractmethod | ||
def create_quant_map(): | ||
raise NotImplementedError | ||
|
||
|
||
class EightBitOptimizer(ABC): | ||
@abstractmethod | ||
def optimizer_update_32bit(): | ||
"""Needed only for testing purposes.""" | ||
raise NotImplementedError | ||
|
||
@abstractmethod | ||
def optimizer_update_8bit_blockwise(): | ||
raise NotImplementedError | ||
|
||
|
||
class CompleteBnbAlgorithmsInterface( | ||
RequiredUtilities, FourBitMatmul, EightBitMatMul, KBitQuantization, EightBitOptimizer | ||
): | ||
pass |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something to think about here is that for the nested quantization, the interface for
KBitQuantization
is needed (quantize_blockwise/dequantize_blockwise)