Set --sysroot to sysroot generated by rust_toolchain #2223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daivinhtran
force-pushed
the
set-toolchain-generated-sysroot-to-rustc
branch
from
0fb5fef to
249b821
Compare
daivinhtran
force-pushed
the
set-toolchain-generated-sysroot-to-rustc
branch
from
e6ae298 to
d667de6
Compare
UebelAndre
requested changes
Oct 27, 2023
UebelAndre
requested changes
Oct 27, 2023
daivinhtran
force-pushed
the
set-toolchain-generated-sysroot-to-rustc
branch
6 times, most recently
from
7f854c1 to
00078eb
Compare
@UebelAndre Done. |
daivinhtran
force-pushed
the
set-toolchain-generated-sysroot-to-rustc
branch
from
ced7397 to
d34afde
Compare
UebelAndre
requested changes
Oct 30, 2023
UebelAndre
requested changes
Oct 31, 2023
UebelAndre
requested changes
Oct 31, 2023
daivinhtran
force-pushed
the
set-toolchain-generated-sysroot-to-rustc
branch
from
2bc828b to
b1a7e1a
Compare
daivinhtran
force-pushed
the
set-toolchain-generated-sysroot-to-rustc
branch
from
d985ad8 to
6eb7a7c
Compare
UebelAndre
requested changes
Oct 31, 2023
daivinhtran
force-pushed
the
set-toolchain-generated-sysroot-to-rustc
branch
from
d1bb016 to
cddb545
Compare
daivinhtran
force-pushed
the
set-toolchain-generated-sysroot-to-rustc
branch
from
cddb545 to
f8027f2
Compare
UebelAndre
approved these changes
Oct 31, 2023
UebelAndre
added a commit
that referenced
this pull request
Nov 25, 2023
#2223 only sets `--@rules_rust//rust/settings:experimental_toolchain_generated_sysroot` in a few targets on CI. This PR defaults the feature flag to `True`. This ensures the feature flag works at a larger scope because we remove it. --------- Co-authored-by: UebelAndre <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2039