Skip to content

Commit a09c6d9

Browse files
Vinh TranUebelAndre
Vinh Tran
andauthored
Default experimental_toolchain_generated_sysroot to True (#2277)
#2223 only sets `--@rules_rust//rust/settings:experimental_toolchain_generated_sysroot` in a few targets on CI. This PR defaults the feature flag to `True`. This ensures the feature flag works at a larger scope because we remove it. --------- Co-authored-by: UebelAndre <[email protected]>
1 parent 4aa6550 commit a09c6d9

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

.bazelci/presubmit.yml

-2
Original file line numberDiff line numberDiff line change
@@ -92,10 +92,8 @@ tasks:
9292
test_targets: *default_linux_targets
9393
build_flags:
9494
- "--compilation_mode=opt"
95-
- "--@rules_rust//rust/settings:experimental_toolchain_generated_sysroot=True"
9695
test_flags:
9796
- "--compilation_mode=opt"
98-
- "--@rules_rust//rust/settings:experimental_toolchain_generated_sysroot=True"
9997
macos_opt:
10098
name: Opt Mode
10199
platform: macos

rust/settings/BUILD.bazel

+1-1
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,6 @@ bzl_library(
6868
# A flag to set rustc --sysroot flag to the sysroot generated by rust_toolchain
6969
incompatible_flag(
7070
name = "experimental_toolchain_generated_sysroot",
71-
build_setting_default = False,
71+
build_setting_default = True,
7272
issue = "https://github.com/bazelbuild/rules_rust/issues/2039",
7373
)

0 commit comments

Comments
 (0)