Refactor E2E tests in CI #730
Open
+103
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| platforms: ${{ inputs.multi_arch && 'linux/amd64,linux/arm64' || 'linux/amd64' }} | ||
| cache-from: type=gha | ||
| cache-to: type=gha,mode=max | ||
| outputs: ${{ inputs.export_artifacts && 'type=docker,dest=/tmp/server.tar' || '' }} |
There was a problem hiding this comment.
The key 'outputs' should be 'output' in the docker/build-push-action step.
Suggested change
| outputs: ${{ inputs.export_artifacts && 'type=docker,dest=/tmp/server.tar' || '' }} | |
| output: ${{ inputs.export_artifacts && 'type=docker,dest=/tmp/server.tar' || '' }} |
| platforms: ${{ inputs.multi_arch && 'linux/amd64,linux/arm64' || 'linux/amd64' }} | ||
| cache-from: type=gha | ||
| cache-to: type=gha,mode=max | ||
| outputs: ${{ inputs.export_artifacts && 'type=docker,dest=/tmp/jobrunner.tar' || '' }} |
There was a problem hiding this comment.
The key 'outputs' should be 'output' in the docker/build-push-action step.
Suggested change
| outputs: ${{ inputs.export_artifacts && 'type=docker,dest=/tmp/jobrunner.tar' || '' }} | |
| output: ${{ inputs.export_artifacts && 'type=docker,dest=/tmp/jobrunner.tar' || '' }} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reshuffles how the E2E tests are run in CI.
Previously test-e2e-desktop-complete and test-e2e-server would each build Server and Jobrunner, which was not only wasteful but also slightly non-representative of the final build.
Now we reuse the build_shared action to build the Docker images just like we would for a release, just without pushing them. We then import them into the test steps and run the tests against a docker-compose'd version.