Skip to content

Fix Firefox compatibility by handling null ICE candidates #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2025
Merged

Fix Firefox compatibility by handling null ICE candidates #632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion examples/answerer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ class Answerer {
// `candidate` will be the empty string if the event indicates that there are no further candidates
// to come in this generation, or null if all ICE gathering on all transports is complete.
// https://developer.mozilla.org/en-US/docs/Web/API/RTCPeerConnection/icecandidate_event
if (candidate) {
if (candidate && candidate.candidate) {
console.log(this._loggingPrefix, 'Generated ICE candidate for', this._remoteClientId || 'remote');
console.debug(this._loggingPrefix, 'ICE candidate:', candidate);

Expand All @@ -110,6 +110,8 @@ class Answerer {
console.log(this._loggingPrefix, 'Not sending ICE candidate to', this._remoteClientId || 'remote');
}
}
} else if (candidate && !candidate.candidate) {
//firefox special case, candidate with null candidate field
} else {
console.log(this._loggingPrefix, 'All ICE candidates have been generated for', this._remoteClientId || 'remote');

Expand Down
4 changes: 3 additions & 1 deletion examples/viewer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -769,7 +769,7 @@ async function startViewer(localView, remoteView, formValues, onStatsReport, rem

// Send any ICE candidates to the other peer
viewer.peerConnection.addEventListener('icecandidate', ({ candidate }) => {
if (candidate) {
if (candidate && candidate.candidate) {
console.log('[VIEWER] Generated ICE candidate');
console.debug('ICE candidate:', candidate);

Expand All @@ -782,6 +782,8 @@ async function startViewer(localView, remoteView, formValues, onStatsReport, rem
console.log('[VIEWER] Not sending ICE candidate');
}
}
} else if (candidate && !candidate.candidate) {
//firefox special case, candidate with null candidate field
} else {
console.log('[VIEWER] All ICE candidates have been generated');

Expand Down