Skip to content

Conversation

@YPandas
Copy link
Contributor

@YPandas YPandas commented Oct 24, 2025

Issue #, if available:

  • Firefox sends a null candidate to signal end of ICE gathering, which caused parsing errors when trying to process these candidates.

Description of changes:

  • Add null checks before sending ICE candidates
  • Prevents errors when ICE gathering completes and the candidate with field 'candidate' being null is sent

BEFORE
image

AFTER
image

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

unicornss
unicornss previously approved these changes Oct 24, 2025
Copy link
Contributor

@unicornss unicornss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let us test in diff browsers

@YPandas YPandas requested a review from sirknightj October 24, 2025 22:14
@YPandas YPandas requested a review from sirknightj October 31, 2025 01:31
@sirknightj sirknightj changed the base branch from release-v2.4.4 to develop October 31, 2025 02:28
@sirknightj sirknightj dismissed unicornss’s stale review October 31, 2025 02:28

The base branch was changed.

@YPandas YPandas requested a review from sirknightj October 31, 2025 17:42
@sirknightj sirknightj added Samples Questions related to Samples 2.4.5 labels Oct 31, 2025
@YPandas YPandas merged commit a370293 into awslabs:develop Nov 3, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.4.5 compatibility Samples Questions related to Samples

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants