Skip to content

fix codegen when a model explicitly specifies the enum value NOT_SET #3685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbiscigl merged 1 commit into from
Jan 9, 2026
Merged

fix codegen when a model explicitly specifies the enum value NOT_SET #3685

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .../util/awsclientgenerator/domainmodels/codegeneration/cpp/PlatformAndKeywordSanitizer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,17 @@ public class PlatformAndKeywordSanitizer {
public static String fixEnumValue (String enumValue) {
String enumMemberName = enumValue;

// NOT_SET is a special value in C++ SDK enums used in two scenarios:
// 1. When an enum cannot be deserialized from a string value
// 2. When accessing an enum created from an invalid string value
// Note: Services may still use NOT_SET as a valid key in maps
//
// TODO: model this as a crt or std optional to represent "absent of value"
// instead of using a common-ish predetermined value.
if (enumValue.equals("NOT_SET")) {
return "NOT_SET_VALUE";
}

for (String invalid : ENUM_CHARS_MAPPING.keySet()) {
enumMemberName = enumMemberName.replace(invalid, ENUM_CHARS_MAPPING.get(invalid));
}
Expand Down