Skip to content

Conversation

@sbiscigl
Copy link
Contributor

@sbiscigl sbiscigl commented Jan 8, 2026

Description of changes:

If a service model uses the enum value NOT_SET it will conflict with the SDKs implicit enum value of NOT_SET which is encountered when:

  • an enum cannot be deserialized from a string value
  • accessing an enum created from an invalid string value

This re-maps the modeled value from NOT_SET to NOT_SET_VALUE. this really should be modeled as a optional in a future breaking release.

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sbiscigl sbiscigl marked this pull request as ready for review January 8, 2026 22:27
@sbiscigl sbiscigl merged commit ed9ee11 into main Jan 9, 2026
6 checks passed
@sbiscigl sbiscigl deleted the fix-codegen-notset branch January 9, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants