fix(docker): build simple planning simulator with core - #7311
Merged
Conversation
Keep the simulator manifests out of the core dependency stage so rosdep does not install released Autoware Core packages before the source overlay is built. Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
xmfcx
marked this pull request as ready for review
September 8, 2026 07:08
xmfcx
requested review from
isamu-takagi,
mitsudome-r,
oguzkaganozt and
youtalk
as code owners
September 8, 2026 07:08
mitsudome-r
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
autoware_simple_planning_simulatorfrom the generic Core dependency build into the Core source overlay.autoware_coreandautoware_rviz_pluginsincore-devel.autoware_coredependency with released Autoware Debian packages.Why
autoware_simple_planning_simulatordepends onautoware_core. Exposing its manifests incore-dependencieswhile hidingautoware_corecauses rosdep to install released Core packages. In the failing Humble nightly job, this installedros-humble-autoware-point-types1.9.0, and the later source build found stale headers under/opt/ros/humblewhile compilingautoware_euclidean_cluster.Building the simulator repository in the same source overlay as
autoware_corepreserves the intended dependency boundary and prevents those released packages from entering the image.Test plan
docker buildx bake -f docker/docker-bake.hcl core-devel --print.ROS_DISTRO=humble docker buildx bake -f docker/docker-bake.hcl core-devel --progress=plain.ROS_DISTRO=humble docker buildx bake -f docker/docker-bake.hcl universe-devel --progress=plain.ros-humble-autoware-*Debian packages.AI usage
AI usage: Investigated and implemented with Codex from the reported failing nightly job and the requested Docker stage boundary.
Self-review: Not reviewed yet.
Verification: Built the Humble `core-devel` and `universe-devel` images; `universe-devel` finished all 538 packages, including `autoware_simple_planning_simulator` and `autoware_euclidean_cluster`, and the final images contained no `ros-humble-autoware-*` Debian packages.
Docker bake validation
docker buildx bake -f docker/docker-bake.hcl core-devel --printexited with status 0 and resolved theautoware:core-devel-humbletarget.Humble Core image build
ROS_DISTRO=humble docker buildx bake -f docker/docker-bake.hcl core-devel --progress=plainexited with status 0.PointCloudClassificationheader and noros-humble-autoware-*Debian packages.Humble Universe image build
ROS_DISTRO=humble docker buildx bake -f docker/docker-bake.hcl universe-devel --progress=plainexited with status 0.538 packages finished [26min 45s];autoware_simple_planning_simulatorandautoware_euclidean_clusterfinished successfully.ros-humble-autoware-*Debian packages.colcon testrun and the GitHub Actions job were not run.