Skip to content

fix(docker): build simple planning simulator with core - #7311

Merged
xmfcx merged 1 commit into
mainfrom
fix/docker-core-simple-planning-simulator
Sep 8, 2026
Merged

fix(docker): build simple planning simulator with core#7311
xmfcx merged 1 commit into
mainfrom
fix/docker-core-simple-planning-simulator

Conversation

@xmfcx

@xmfcx xmfcx commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Description

  • Move autoware_simple_planning_simulator from the generic Core dependency build into the Core source overlay.
  • Build it with autoware_core and autoware_rviz_plugins in core-devel.
  • Prevent rosdep from satisfying its autoware_core dependency with released Autoware Debian packages.

Why

autoware_simple_planning_simulator depends on autoware_core. Exposing its manifests in core-dependencies while hiding autoware_core causes rosdep to install released Core packages. In the failing Humble nightly job, this installed ros-humble-autoware-point-types 1.9.0, and the later source build found stale headers under /opt/ros/humble while compiling autoware_euclidean_cluster.

Building the simulator repository in the same source overlay as autoware_core preserves the intended dependency boundary and prevents those released packages from entering the image.


Test plan

  • Run docker buildx bake -f docker/docker-bake.hcl core-devel --print.
  • Run ROS_DISTRO=humble docker buildx bake -f docker/docker-bake.hcl core-devel --progress=plain.
  • Run ROS_DISTRO=humble docker buildx bake -f docker/docker-bake.hcl universe-devel --progress=plain.
  • Confirm the final Humble images contain the workspace packages and no ros-humble-autoware-* Debian packages.

AI usage

AI usage: Investigated and implemented with Codex from the reported failing nightly job and the requested Docker stage boundary.

Self-review: Not reviewed yet.

Verification: Built the Humble `core-devel` and `universe-devel` images; `universe-devel` finished all 538 packages, including `autoware_simple_planning_simulator` and `autoware_euclidean_cluster`, and the final images contained no `ros-humble-autoware-*` Debian packages.

Docker bake validation

  • docker buildx bake -f docker/docker-bake.hcl core-devel --print exited with status 0 and resolved the autoware:core-devel-humble target.
  • Jazzy and ARM64 image configurations were not validated.

Humble Core image build

  • ROS_DISTRO=humble docker buildx bake -f docker/docker-bake.hcl core-devel --progress=plain exited with status 0.
  • The dependency stage finished 52 packages, and the source-overlay stage finished 84 packages.
  • The resulting image contained the workspace PointCloudClassification header and no ros-humble-autoware-* Debian packages.

Humble Universe image build

  • ROS_DISTRO=humble docker buildx bake -f docker/docker-bake.hcl universe-devel --progress=plain exited with status 0.
  • The build reported 538 packages finished [26min 45s]; autoware_simple_planning_simulator and autoware_euclidean_cluster finished successfully.
  • The resulting image contained both workspace package manifests and no ros-humble-autoware-* Debian packages.
  • A separate colcon test run and the GitHub Actions job were not run.

Keep the simulator manifests out of the core dependency stage so rosdep does not install released Autoware Core packages before the source overlay is built.

Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
@xmfcx xmfcx added type:build Tooling and infrastructure around building the Autoware. type:containers Docker containers, containerization of components, or container orchestration. run:health-check Run health-check labels Sep 8, 2026
@xmfcx xmfcx self-assigned this Sep 8, 2026
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@xmfcx
xmfcx marked this pull request as ready for review September 8, 2026 07:08
@xmfcx
xmfcx merged commit 87f7b60 into main Sep 8, 2026
27 of 33 checks passed
@xmfcx
xmfcx deleted the fix/docker-core-simple-planning-simulator branch September 8, 2026 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run:health-check Run health-check type:build Tooling and infrastructure around building the Autoware. type:containers Docker containers, containerization of components, or container orchestration.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants