fix(docker): build simple planning simulator with core - #33
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Keep autoware_simple_planning_simulator out of core-dependencies so rosdep cannot satisfy its autoware_core deps with released Debian packages. Build it in the core-devel source overlay instead. That contamination made Humble universe-devel pick stale /opt/ros/humble headers (e.g. autoware_point_types) while compiling packages such as autoware_euclidean_cluster. Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: YILIANG LIU <yiliangzaimit@googlemail.com>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
autoware_simple_planning_simulatorwas added toautoware.reposin autowarefoundation#7213, butdocker/core.Dockerfilestill treated onlyautoware_coreandautoware_rviz_pluginsas the Core source overlay.The simulator depends on packages that live inside
autoware_core(autoware_motion_utils,autoware_vehicle_info_utils,autoware_lanelet2_utils, …). Leaving its manifests incore-dependencieswhile hidingautoware_coremakes rosdep install releasedros-${ROS_DISTRO}-autoware-*Debian packages. Humble then compiles later packages (for exampleautoware_euclidean_cluster) against stale headers under/opt/ros/humble.This broke the Humble nightly
universe-develimage (health-check run 34104016537). The same overlay split is on this fork, so the same contamination happens oncore-devel/universe-develbuilds here.Fix: exclude the simulator from
core-dependenciesand build it withautoware_coreincore-devel, matching the existing overlay boundary.How was this PR tested?
autoware.repospinscore/autoware_simple_planning_simulatorat1.0.0.package.xmldepends onautoware_corepackages that exist inautoware_core1.9.0.core.Dockerfilepreviously removed onlyautoware_coreandautoware_rviz_pluginsfrom the dependency stage.docker buildx bakewas not run in this environment (too heavy); the Dockerfile now lists the simulator in every overlay exclusion, copy, mount, andcolconpath.Upstream reference: autowarefoundation#7311.