chore: update agnocast to 2.4.0 - #7292
Merged
Merged
Conversation
Signed-off-by: Koichi Imai <koichi.imai.2@tier4.jp>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Koichi98
marked this pull request as ready for review
September 1, 2026 07:28
Koichi98
requested review from
isamu-takagi,
mitsudome-r,
oguzkaganozt,
xmfcx and
youtalk
as code owners
September 1, 2026 07:28
xmfcx
requested changes
Sep 1, 2026
xmfcx
left a comment
xmfcx
left a comment
Contributor
There was a problem hiding this comment.
Could you update here too?
autoware/ansible/roles/agnocast/README.md
Line 12 in 0740cbc
This was referenced Sep 1, 2026
Koichi98
marked this pull request as draft
September 1, 2026 12:29
…discovery_agent agnocast 2.4.0 adds ros2agnocast_discovery_agent, whose setup.py data_files installs systemd/README.md alongside agnocast-domain-bridge.service.example. src/**/*.md kept it out of the Docker build context, so colcon build failed in the container with "can't copy 'systemd/README.md'" while local builds passed. Signed-off-by: koichiimai <koichi.imai.2@tier4.jp>
Koichi98
force-pushed
the
update_agnocast_to_2.4.0
branch
from
September 1, 2026 21:58
bd42b3c to
e963f90
Compare
Collaborator
Author
|
@xmfcx I also pushed a |
Koichi98
marked this pull request as ready for review
September 1, 2026 22:04
xmfcx
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update agnocast from 2.3.5 to 2.4.0 (
repositories/autoware.reposand theagnocastansible role).Also adds one
.dockerignoreexception. 2.4.0 introducesros2agnocast_discovery_agent, whosesetup.pyinstallssystemd/README.md— the operating instructions for theagnocast-domain-bridge.service.exampleshipped next to it.src/**/*.md(added in #5009 to cut image size) excludes it from the Docker build context, socolcon buildfails in the container withcan't copy 'systemd/README.md'while a local build passes.The exception restores a single 2 KB file. #5009's saving came mostly from
.git— its own description says "the most effective one is.git" — and.svg/.asc/.gifstay excluded; all 636.mdfiles undersrc/total 3.3 MB on a local checkout. Same shape as #5187 and #5263, which restored.csv/.pngfor the same reason.How was this PR tested?
Confirmed the
2.4.0tag exists in https://github.com/autowarefoundation/agnocast, and thatagnocast-heaphook-v2.4.0andagnocast-kmod-v2.4.0are available from the agnocast PPA.Health-check failed before the
.dockerignorechange witherror: can't copy 'systemd/README.md'inros2agnocast_discovery_agenton all five jobs (run).Verified the exception with a scratch
docker buildover the same layout:systemd/README.mdreaches the context while othersrc/**/*.mdfiles stay excluded.