chore(codeowners): add Koichi98 as owner of the agnocast role - #7294
Merged
Conversation
CODEOWNERS is last-match-wins with no owner merging, so the new line repeats the ansible/** owners and appends @Koichi98. Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
xmfcx
marked this pull request as ready for review
September 1, 2026 08:20
xmfcx
requested review from
isamu-takagi,
mitsudome-r,
oguzkaganozt and
youtalk
as code owners
September 1, 2026 08:20
Koichi98
approved these changes
Sep 1, 2026
pull Bot
pushed a commit
to Stars1233/autoware
that referenced
this pull request
Sep 1, 2026
…n#7293) * docs(ansible): align agnocast README with the role The README described the role at v2.1.2. The tasks changed after that. - Set the version to 2.3.5. - Point the upstream link to autowarefoundation/agnocast. - List the three overridable defaults under Inputs. - Add the ansible-playbook command with the agnocast tag. - Install the kernel headers before the kmod, as the role does. - Check the dkms state with `dkms status agnocast/<version> | grep -q installed`. The old check had no `$` in `{agnocast_version}` and never matched. - Load the module at boot via /etc/modules-load.d/agnocast.conf. Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org> * chore(codeowners): add Koichi98 as owner of the agnocast role (autowarefoundation#7294) CODEOWNERS is last-match-wins with no owner merging, so the new line repeats the ansible/** owners and appends @Koichi98. Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org> * docs(ansible): drop the manual snippet from the agnocast README The snippet was a second copy of the role in shell, and it drifted: an old version, add-apt-repository, and a dkms check that never matched. The Ansible command is now the only installation step, as in the acados and qt5ct_setup READMEs. Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org> * chore(codeowners): use the email of Koichi98 for the agnocast role The other owners in the file are email addresses. The GitHub handle was the only exception. Signed-off-by: Mete Fatih Cırıt <mfc@autoware.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
@Koichi98as a code owner ofansible/roles/agnocast/. Koichi98 authored the agnocast version bumps in this repository.CODEOWNERS is last-match-wins and does not merge owners across lines. The new
ansible/roles/agnocast/**line therefore repeats the fiveansible/**owners and appends@Koichi98. Without the repeat, the maintainers stop getting review requests for that role.The entry uses the GitHub handle. CODEOWNERS accepts a handle or an email, and the account has no public email. GitHub requests reviews from a code owner only when that user has write access to the repository. Koichi98 needs that access before the entry takes effect.
How to verify
.github/CODEOWNERSon the branch in the GitHub UI. GitHub marks the line if an owner is unknown or has no write access.gh api "repos/autowarefoundation/autoware/codeowners/errors?ref=chore/codeowners-agnocast"and make sure that the output is{"errors":[]}.AI usage
AI usage: written with Claude Code on request
Self-review: Not reviewed yet.
Verification:
pre-commitpassed on the file. The GitHub CODEOWNERS errors API returns{"errors":[]}for the branch, after Koichi98 received write access.pre-commit
pre-commit run --files .github/CODEOWNERSprettierpassed,fix end of filespassedCODEOWNERS errors API
gh api "repos/autowarefoundation/autoware/codeowners/errors?ref=chore/codeowners-agnocast", after the push.Unknown owner on line 6: make sure @Koichi98 exists and has write access to the repository{"errors":[]}ansible/roles/agnocast/. The first such PR after merge shows itPermission lookup
gh api repos/autowarefoundation/autoware/collaborators/Koichi98/permissionpermission=read role=triage. This is the effective permission, teams includedpermission=write role=write