Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Turkish translation #367

Merged
merged 19 commits into from
Jan 24, 2025
Merged

Add Turkish translation #367

merged 19 commits into from
Jan 24, 2025

Conversation

RPCdotcom
Copy link
Contributor

No description provided.

Copy link
Member

@nazar-pc nazar-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know the language, but let's merge and improve it later.
Thank you!

@nazar-pc nazar-pc changed the title Language : Turkish Pull Request Add Turkish translation Jan 11, 2025
@nazar-pc nazar-pc enabled auto-merge (squash) January 11, 2025 18:36
Copy link
Member

@nazar-pc nazar-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there were some translation lines added since you created translations, you can see in https://github.com/autonomys/space-acres/actions/runs/12726465906/job/35475314672?pr=367#step:16:1941 what they are

res/translations/tr/messages.ftl Outdated Show resolved Hide resolved
res/translations/tr/messages.ftl Outdated Show resolved Hide resolved
auto-merge was automatically disabled January 11, 2025 18:48

Head branch was pushed to by a user without write access

@nazar-pc
Copy link
Member

@RPCdotcom friendly ping here

@RPCdotcom RPCdotcom requested a review from nazar-pc January 24, 2025 15:48
@nazar-pc
Copy link
Member

Please read my review comment carefully, this PR does not compile with main branch and can't be merged as the result

@RPCdotcom
Copy link
Contributor Author

Now updated with main branch Do you want me to put up a new PR?

@nazar-pc
Copy link
Member

Some translations are currently missing, you should add them

@RPCdotcom
Copy link
Contributor Author

running_node_connections_tooltip = {$connected_peers}/{$expected_peers} peers connected, click for details about required P2P ports

added ;

running_node_connections_tooltip = {$connected_peers}/{$expected_peers} peersler bağlı, gerekli P2P portları hakkında detaylar için tıklayın

@nazar-pc
Copy link
Member

There is still at least one translation missing, see CI logs

@RPCdotcom
Copy link
Contributor Author

running_farmer_button_resume_plotting - added

running_farmer_button_resume_plotting = Alan oluşturmaya devam et

I'm trying to see what else is missing

Copy link
Member

@nazar-pc nazar-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@nazar-pc nazar-pc enabled auto-merge (squash) January 24, 2025 19:34
@nazar-pc nazar-pc merged commit 88f68ee into autonomys:main Jan 24, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants