Skip to content

added app rating and review prompt #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jayana-cpc wants to merge 8 commits into
base: master
Choose a base branch
from
Open

added app rating and review prompt #431

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a86a1e8
added app rating and review prompt
jayana-cpc Sep 30, 2025
1a644ee
modified app rating prompting frequency
jayana-cpc Oct 6, 2025
972fa39
Merge branch 'origin/master' into jayana/review-prompt
jayana-cpc Oct 7, 2025
9791af8
implemented suggested edits for pr
jayana-cpc Oct 14, 2025
8767137
Merge master into jayana/review-prompt
jayana-cpc Oct 14, 2025
7b1dcd9
implemented suggested edits for pr (round 2)
jayana-cpc Oct 21, 2025
bf9a608
Merge branch 'master' of https://github.com/asuc-octo/berkeley-mobile…
jayana-cpc Oct 21, 2025
82eca92
Addressed missed changes
jayana-cpc Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions berkeley-mobile.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,8 @@
E8FCD6842C374A81004B66A3 /* SwiftSoup in Frameworks */ = {isa = PBXBuildFile; productRef = E8FCD6832C374A81004B66A3 /* SwiftSoup */; };
E8FCD6882C38AEC9004B66A3 /* String+Extension.swift in Sources */ = {isa = PBXBuildFile; fileRef = E8FCD6872C38AEC9004B66A3 /* String+Extension.swift */; };
E8FCD68A2C3A382F004B66A3 /* EventScrapper.swift in Sources */ = {isa = PBXBuildFile; fileRef = E8FCD6892C3A382F004B66A3 /* EventScrapper.swift */; };
FAFF001C2E84C62100551C44 /* ReviewPrompter.swift in Sources */ = {isa = PBXBuildFile; fileRef = FAFF001B2E84C61B00551C44 /* ReviewPrompter.swift */; };
FD44FE6125EB0EAD00F713EB /* AlertView.swift in Sources */ = {isa = PBXBuildFile; fileRef = FD44FE6025EB0EAD00F713EB /* AlertView.swift */; };
FDD7946C260FE09D00ABE60E /* Colors+AlertView.swift in Sources */ = {isa = PBXBuildFile; fileRef = FDD7946B260FE09D00ABE60E /* Colors+AlertView.swift */; };
/* End PBXBuildFile section */

Expand Down Expand Up @@ -383,6 +385,8 @@
E8EBE7612CEC2FD700A220BB /* SafetyLogDetailView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SafetyLogDetailView.swift; sourceTree = "<group>"; };
E8FCD6872C38AEC9004B66A3 /* String+Extension.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "String+Extension.swift"; sourceTree = "<group>"; };
E8FCD6892C3A382F004B66A3 /* EventScrapper.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = EventScrapper.swift; sourceTree = "<group>"; };
FAFF001B2E84C61B00551C44 /* ReviewPrompter.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ReviewPrompter.swift; sourceTree = "<group>"; };
FD44FE6025EB0EAD00F713EB /* AlertView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = AlertView.swift; sourceTree = "<group>"; };
FDD7946B260FE09D00ABE60E /* Colors+AlertView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "Colors+AlertView.swift"; sourceTree = "<group>"; };
/* End PBXFileReference section */

Expand Down Expand Up @@ -534,6 +538,7 @@
1396012D23865E2E005E4788 /* Common */ = {
isa = PBXGroup;
children = (
FAFF001B2E84C61B00551C44 /* ReviewPrompter.swift */,
2913595524B135B600DE9AD6 /* DetailView */,
13B39AB123E777AC0039FBA2 /* FilterView */,
29481560253274CA00D113B6 /* Images */,
Expand Down Expand Up @@ -1143,6 +1148,7 @@
E8C2BDA72D912B3A00165554 /* CalendarView.swift in Sources */,
E83B6DA52D7A85D500AA9422 /* GymOccupancyScrapper.swift in Sources */,
E8472B062DE453D6005C24EA /* BMAddedCalendarStatusOverlayView.swift in Sources */,
FAFF001C2E84C62100551C44 /* ReviewPrompter.swift in Sources */,
13EA64D02399D50C00FD8E13 /* DataManager.swift in Sources */,
E80330EB2CE431C200DC9574 /* DepthButtonStyle.swift in Sources */,
C14CCB612D9CC2730075FE69 /* BMFilterButton.swift in Sources */,
Expand Down
1 change: 1 addition & 0 deletions berkeley-mobile/AppDelegate.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ class AppDelegate: UIResponder, UIApplicationDelegate {

func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?) -> Bool {
FirebaseApp.configure()
UserDefaults.standard.increment(forKey: UserDefaultsKeys.numAppLaunchForAppStoreReview)
self.checkForUpdate()
DataManager.shared.fetchAll()
BMLocationManager.shared.requestLocation()
Expand Down
37 changes: 37 additions & 0 deletions berkeley-mobile/Common/ReviewPrompter.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
//
// ReviewPrompter.swift
// berkeley-mobile
//
// Created by Jayana Nanayakkara on 9/24/25.
// Copyright © 2025 ASUC OCTO. All rights reserved.
//

import Foundation
import StoreKit
import UIKit

enum ReviewPrompter {
Copy link
Collaborator

@justinwongeecs justinwongeecs Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is ReviewPrompter an enum?

Shouldn't it be a class instead? Perhaps a singleton? https://developer.apple.com/documentation/swift/managing-a-shared-resource-using-a-singleton

private static let numLaunchesForReview: Int = 30

private static func shouldPromptForReview() -> Bool {
let key = UserDefaultsKeys.numAppLaunchForAppStoreReview.rawValue
let launches = UserDefaults.standard.integer(forKey: key)
print("DEBUG: ",launches)
Copy link
Collaborator

@justinwongeecs justinwongeecs Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove print statement

if launches == numLaunchesForReview {
UserDefaults.standard.set(0, forKey: key)
return true
}
return false
}

@MainActor
static func presentReviewIfNeeded() {
guard shouldPromptForReview() else { return }
Copy link
Collaborator

@justinwongeecs justinwongeecs Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For guard statements have the return on a new line. Like something like this:

guard shouldPromptForReview() else {
    return
}

Copy link
Collaborator

@justinwongeecs justinwongeecs Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the return isn't on a new line still


if let scene = UIApplication.shared.connectedScenes
.first(where: { $0.activationState == .foregroundActive }) as? UIWindowScene {
AppStore.requestReview(in: scene)

Copy link
Collaborator

@justinwongeecs justinwongeecs Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove newline

}
}
}
1 change: 1 addition & 0 deletions berkeley-mobile/Events/EventDetailView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ struct EventDetailView: View {
withoutAnimation {
eventsViewModel.alert = BMAlert(title: "Open in Safari?", message: message, type: .action) {
UIApplication.shared.open(url)

Copy link
Collaborator

@justinwongeecs justinwongeecs Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove newline

Copy link
Collaborator

@justinwongeecs justinwongeecs Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is still a newline in the commit

}
alertType = nil
}
Expand Down
6 changes: 6 additions & 0 deletions berkeley-mobile/Home/Map/MapViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,12 @@ class MapViewController: UIViewController, SearchDrawerViewDelegate {

self.createMapMarkerDropdownButton()
self.showSelectedMapMarkerTypeAnnotations(forType: types.first!)

DispatchQueue.main.asyncAfter(deadline: .now() + 1.0) {
if self.mainContainer?.presentedViewController == nil {
ReviewPrompter.presentReviewIfNeeded()
}
}
}
}

Expand Down
2 changes: 1 addition & 1 deletion berkeley-mobile/MainContainerViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import UIKit
import SwiftUI

class MainContainerViewController: UIViewController, MainDrawerViewDelegate {

// MainDrawerViewDelegate properties
Comment on lines -13 to 14
Copy link
Collaborator

@justinwongeecs justinwongeecs Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this change?

var drawerStack: [DrawerViewDelegate] = []
var positions: [DrawerState?] = []
Expand Down
5 changes: 5 additions & 0 deletions berkeley-mobile/Utils/UserDefaults+Extension.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import Foundation

enum UserDefaultsKeys: String {
case numAppLaunchForFeedbackForm = "numAppLaunchForFeedbackForm"
case numAppLaunchForAppStoreReview = "numAppLaunchForAppStoreReview"
case academicEventsLastSavedDate = "academicEventsLastSavedDate"
case campuswideEventsLastSavedDate = "campuswideEventsLastSavedDate"
case recentSearches = "recentSearches"
Expand All @@ -27,4 +28,8 @@ extension UserDefaults {
func data(forKey key: UserDefaultsKeys) -> Data? {
data(forKey: key.rawValue)
}

func increment(forKey key: UserDefaultsKeys) {
set(integer(forKey: key) + 1, forKey: key)
}
}