added app rating and review prompt #431
Conversation
| @@ -91,6 +91,7 @@ struct EventDetailView: View { | |||
| withoutAnimation { | |||
| eventsViewModel.alert = BMAlert(title: "Open in Safari?", message: message, type: .action) { | |||
| UIApplication.shared.open(url) | |||
|
|
|||
There was a problem hiding this comment.
there is still a newline in the commit
| return false | ||
| } | ||
| func presentReviewIfNeeded() { | ||
| guard shouldPromptForReview() else { return } |
There was a problem hiding this comment.
For guard statements have the return on a new line. Like something like this:
guard shouldPromptForReview() else {
return
}
There was a problem hiding this comment.
the return isn't on a new line still
justinwongeecs
left a comment
justinwongeecs
left a comment
There was a problem hiding this comment.
Some of the resolved changes were not reflected in the code?
| private static func shouldPromptForReview() -> Bool { | ||
| let key = UserDefaultsKeys.numAppLaunchForAppStoreReview.rawValue | ||
| let launches = UserDefaults.standard.integer(forKey: key) | ||
| print("DEBUG: ",launches) |
There was a problem hiding this comment.
remove print statement
| return false | ||
| } | ||
| func presentReviewIfNeeded() { | ||
| guard shouldPromptForReview() else { return } |
There was a problem hiding this comment.
the return isn't on a new line still
| @@ -91,6 +91,7 @@ struct EventDetailView: View { | |||
| withoutAnimation { | |||
| eventsViewModel.alert = BMAlert(title: "Open in Safari?", message: message, type: .action) { | |||
| UIApplication.shared.open(url) | |||
|
|
|||
There was a problem hiding this comment.
there is still a newline in the commit
|
|
||
| // MainDrawerViewDelegate properties |
There was a problem hiding this comment.
What's this change?
| if let scene = UIApplication.shared.connectedScenes | ||
| .first(where: { $0.activationState == .foregroundActive }) as? UIWindowScene { | ||
| AppStore.requestReview(in: scene) | ||
|
|
| import StoreKit | ||
| import UIKit | ||
|
|
||
| enum ReviewPrompter { |
There was a problem hiding this comment.
Why is ReviewPrompter an enum?
Shouldn't it be a class instead? Perhaps a singleton? https://developer.apple.com/documentation/swift/managing-a-shared-resource-using-a-singleton
ReviewPrompter.swiftto track information relating to review prompting suchlastPromptDate,promptCountPastYear, andsuccessfulEventCountsuccessfulEventCountwhen the user completes certain actions in the appsuccessfulEventCountis greater than 3 and other criteria fulfilled