[ty] Add cycle handling to lazy_default
#20967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
added
bug
MichaReiser
force-pushed
the
micha/add-cycle-handling-to-lazy-defualt
branch
from
77c70c0 to
ef58a8e
Compare
Diagnostic diff on typing conformance testsNo changes detected when running ty on typing conformance tests ✅ |
|
|
AlexWaygood
reviewed
Oct 19, 2025
| @@ -1,2 +1,2 @@ | |||
| spark # too many iterations (in `exported_names` query), `should not be able to access instance member `spark` of type variable IndexOpsLike@astype in inferable position` | |||
There was a problem hiding this comment.
The second of the two panics mentioned here is presumably gone after Doug's recent work in #20677?
MichaReiser
force-pushed
the
micha/add-cycle-handling-to-lazy-defualt
branch
from
ef58a8e to
b2235db
Compare
MichaReiser
commented
Oct 23, 2025
| ``` | ||
|
|
||
|
|
||
| ### Cyclic defaults |
There was a problem hiding this comment.
This is a bit too advanced Python typing for me 😅
I think it would be good to have some reveal_type or other assertion in this test but I need some help with what that assertion could be.
MichaReiser
requested review from
carljm,
dcreager and
sharkdp
as code owners
sharkdp
approved these changes
Oct 23, 2025
crates/ty_python_semantic/resources/mdtest/pep695_type_aliases.md
Outdated
Show resolved
Hide resolved
crates/ty_python_semantic/resources/mdtest/pep695_type_aliases.md
Outdated
Show resolved
Hide resolved
MichaReiser
force-pushed
the
micha/add-cycle-handling-to-lazy-defualt
branch
from
71093fa to
3a52106
Compare
MichaReiser
force-pushed
the
micha/add-cycle-handling-to-lazy-defualt
branch
from
3a52106 to
365b12b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add cycle handling to
lazy_default.Test Plan
Added regression test