Review feedback

Author: MichaReiser

crates/ty_python_semantic/resources/mdtest/pep695_type_aliases.md

@@ -316,10 +316,7 @@ static_assert(is_subtype_of(Bottom[JsonDict], Top[JsonDict]))
 ### Cyclic defaults
 
 ```py
-from __future__ import annotations
-
-from typing import Protocol
-from typing_extensions import TypeVar
+from typing_extensions import Protocol, TypeVar
 
 T = TypeVar("T", default="C", covariant=True)
 
@@ -328,6 +325,9 @@ class P(Protocol[T]):
 
 class C(P[T]):
     pass
+
+reveal_type(C[int]())  # revealed: C[int]
+reveal_type(C())  # revealed: C[Divergent]
 ```
 
 ### Union inside generic

crates/ty_python_semantic/src/types.rs

@@ -8344,7 +8344,7 @@ impl<'db> TypeVarInstance<'db> {
         Some(TypeVarBoundOrConstraints::Constraints(ty))
     }
 
-    #[salsa::tracked(cycle_fn=lazy_default_cycle_recover, cycle_initial=lazy_default_cycle_initial, heap_size=ruff_memory_usage::heap_size)]
+    #[salsa::tracked(cycle_initial=lazy_default_cycle_initial, heap_size=ruff_memory_usage::heap_size)]
     fn lazy_default(self, db: &'db dyn Db) -> Option<Type<'db>> {
         let definition = self.definition(db)?;
         let module = parsed_module(db, definition.file(db)).load(db);
@@ -8391,16 +8391,6 @@ fn lazy_bound_or_constraints_cycle_initial<'db>(
     None
 }
 
-#[allow(clippy::ref_option)]
-fn lazy_default_cycle_recover<'db>(
-    _db: &'db dyn Db,
-    _value: &Option<Type<'db>>,
-    _count: u32,
-    _self: TypeVarInstance<'db>,
-) -> salsa::CycleRecoveryAction<Option<Type<'db>>> {
-    salsa::CycleRecoveryAction::Iterate
-}
-
 fn lazy_default_cycle_initial<'db>(
     _db: &'db dyn Db,
     _self: TypeVarInstance<'db>,