Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conda and pip internal uploads #62

Merged
merged 3 commits into from
Jan 14, 2025
Merged

Conversation

brynpickering
Copy link
Collaborator

This is a flavour of the central Arup composite action to enable uploading packages to https://packages.arup.com for pip packages and https://packages.arup.com/conda for conda packages. This allows internal Arup projects to be installable by pip install or conda install. For conda, it just requires a new channel listing: -c https://packages.arup.com/conda.

In both cases, repos that use the "internal" package destination need to have access to the Arup packages self-hosted runner via a service-now request. I could add that to the README in this repo or in the https://github.com/arup-group/cookiecutter-pypackage/ docs. Or both!

@brynpickering brynpickering requested a review from mfitz December 19, 2024 11:27
@mfitz
Copy link
Contributor

mfitz commented Dec 19, 2024

I could add that to the README in this repo or in the https://github.com/arup-group/cookiecutter-pypackage/ docs. Or both!

Both would be good.

Copy link
Contributor

@mfitz mfitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @brynpickering, and definitely a useful thing to have.

Do you have an example of using one of these amended workflows from a repo to publish a package into the private conda and/or pip artefact repos?

@brynpickering
Copy link
Collaborator Author

It's based on a workflow I set up in https://github.com/arup-group/HeatNet_tool (recent run: https://github.com/arup-group/HeatNet_tool/actions/runs/12409338105/job/34642751052).

Ideally though we'd have it run for one of the CML internal repos using this PR branch. @neilmt might have a suitable repo, if I remember correctly!

@brynpickering
Copy link
Collaborator Author

Ones we could test this on (as they were created with the template and are internal):

https://github.com/arup-group/transaka
https://github.com/arup-group/gbpop
https://github.com/arup-group/texaspop

@gac55 @neilmt would there be any benefit to one of these being available for pip/conda install within the Arup network? Or, conversely, is there a reason why one of these should not be available beyond those with current access to the internal repo?

@neilmt
Copy link

neilmt commented Dec 20, 2024

@brynpickering Transaka is WIP but yes it'd be great to implement this for it.

Copy link
Contributor

@mfitz mfitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@brynpickering brynpickering merged commit 28b7024 into main Jan 14, 2025
1 check passed
@brynpickering brynpickering deleted the internal-package-upload branch January 14, 2025 17:00
@brynpickering brynpickering mentioned this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants