Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conda build #65

Merged
merged 2 commits into from
Feb 10, 2025
Merged

Fix conda build #65

merged 2 commits into from
Feb 10, 2025

Conversation

brynpickering
Copy link
Collaborator

As expected @mfitz, #62 hit some snags in prod (https://github.com/arup-group/HeatNet_tool/pull/76). The fixes here enabled the conda build step to work successfully.

We need to work out how to build a package when it depends on other internal packages - this is a problem for CI tests, too.
@brynpickering brynpickering requested a review from mfitz January 16, 2025 17:39
@brynpickering
Copy link
Collaborator Author

Can confirm that the upload action works fine, just these changes needed for build

Copy link
Contributor

@mfitz mfitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@brynpickering brynpickering merged commit 94ac9b3 into main Feb 10, 2025
1 check passed
@brynpickering brynpickering deleted the fix-conda-build branch February 10, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants